Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sensitive data from log exception for dubbo protocol #5255

Merged
merged 3 commits into from
Oct 31, 2019

Conversation

haiyang1985
Copy link
Member

What is the purpose of the change

For issue: #5254

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@chickenlj chickenlj merged commit 5618b12 into apache:master Oct 31, 2019
@haiyang1985 haiyang1985 mentioned this pull request Nov 1, 2019
6 tasks
FrankBian pushed a commit to FrankBian/dubbo that referenced this pull request Nov 5, 2019
* master: (755 commits)
  add license header for LogUtils file (apache#5272)
  fix how compatibleParamSignatures is generated.
  generic codec & bootstrap api
  Refactor, revert ReferenceConfigCache package change
  init application scope configs before start referencing.
  remove sensitive data from log exception for dubbo protocol (apache#5255)
  add gpg signing plugin for protobuf compiler
  add default implementation for alibaba pacakge compatible class
  add gradle wrapper jar file
  adjust onResponse method for compatibility purpose.
  Refactor ServiceConfig package
  remove useless files
  resolve conflicts after merged master
  enhance generic invocation check
  to process a scenario when service type is not available and service invocation is not generic either
  Fix Dubbo-3990 apache#3990 (apache#5247)
  ignore compile/.gradle
  fix Applicaiton Model related issues.
  use the latest version as the default dependency.
  Postpone checkSubConfig logic in ReferenceConfig (apache#5226)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants