Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-Nacos-NamingService] fix dubbo create nacos multiple identical NamingService #6990

Conversation

minute5
Copy link

@minute5 minute5 commented Dec 6, 2020

What is the purpose of the change

fix dubbo create nacos multiple identical NamingService

more detail: in issue #6988
#6988

Brief changelog

  1. change NacosRegistryFactory createRegistryCacheKey method
  2. remove the timestamp from url as registry cache key

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Dec 6, 2020

Codecov Report

Merging #6990 (a6ad138) into master (3fc2d10) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6990      +/-   ##
============================================
- Coverage     59.44%   59.36%   -0.09%     
+ Complexity      511      507       -4     
============================================
  Files          1028     1028              
  Lines         41519    41523       +4     
  Branches       6037     6038       +1     
============================================
- Hits          24681    24650      -31     
- Misses        14102    14130      +28     
- Partials       2736     2743       +7     
Impacted Files Coverage Δ Complexity Δ
...che/dubbo/registry/nacos/NacosRegistryFactory.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0.00%> (-7.96%) 19.00% <0.00%> (-2.00%)
...ng/transport/dispatcher/all/AllChannelHandler.java 89.65% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
...mmon/serialize/kryo/utils/AbstractKryoFactory.java 75.43% <0.00%> (-3.51%) 0.00% <0.00%> (ø%)
...pache/dubbo/registry/support/AbstractRegistry.java 77.77% <0.00%> (-3.34%) 0.00% <0.00%> (ø%)
...g/apache/dubbo/rpc/protocol/rest/RestProtocol.java 68.21% <0.00%> (-3.11%) 0.00% <0.00%> (ø%)
...g/apache/dubbo/config/AbstractInterfaceConfig.java 85.18% <0.00%> (-2.47%) 0.00% <0.00%> (ø%)
...he/dubbo/rpc/protocol/hessian/HessianProtocol.java 67.46% <0.00%> (-2.41%) 9.00% <0.00%> (ø%)
...ache/dubbo/cache/support/expiring/ExpiringMap.java 40.35% <0.00%> (-1.76%) 0.00% <0.00%> (ø%)
...che/dubbo/remoting/transport/mina/MinaChannel.java 50.00% <0.00%> (-1.32%) 16.00% <0.00%> (-1.00%)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc2d10...a6ad138. Read the comment docs.

@minute5 minute5 closed this Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants