Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the application of spring management repeated monitoring processing dubbo shutdown. #7317

Merged
merged 2 commits into from
May 16, 2021

Conversation

xiaoheng1
Copy link
Contributor

What is the purpose of the change

Solve the repeated monitoring of applications managed by spring
see more detail from #7093

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2021

Codecov Report

Merging #7317 (f247237) into master (34b744b) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7317      +/-   ##
============================================
+ Coverage     59.03%   59.16%   +0.13%     
- Complexity      462      528      +66     
============================================
  Files          1044     1077      +33     
  Lines         42472    43566    +1094     
  Branches       6227     6368     +141     
============================================
+ Hits          25074    25777     +703     
- Misses        14594    14925     +331     
- Partials       2804     2864      +60     
Impacted Files Coverage Δ Complexity Δ
...ing/context/DubboBootstrapApplicationListener.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...onfig/spring/extension/SpringExtensionFactory.java 90.47% <100.00%> (+0.47%) 0.00 <0.00> (ø)
...he/dubbo/rpc/protocol/rmi/RmiRemoteInvocation.java 0.00% <0.00%> (-80.00%) 0.00% <0.00%> (-2.00%)
...org/apache/dubbo/rpc/protocol/rmi/RmiProtocol.java 0.00% <0.00%> (-61.67%) 0.00% <0.00%> (-10.00%)
...g/context/properties/DefaultDubboConfigBinder.java 42.85% <0.00%> (-57.15%) 0.00% <0.00%> (ø%)
.../java/org/apache/dubbo/qos/command/impl/Ready.java 3.33% <0.00%> (-46.67%) 0.00% <0.00%> (ø%)
...tadata/DynamicConfigurationServiceNameMapping.java 47.36% <0.00%> (-41.83%) 0.00% <0.00%> (ø%)
.../cluster/configurator/parser/model/ConfigItem.java 48.00% <0.00%> (-24.00%) 0.00% <0.00%> (ø%)
...in/java/org/apache/dubbo/common/utils/IOUtils.java 65.45% <0.00%> (-22.36%) 0.00% <0.00%> (ø%)
...bbo/common/bytecode/CustomizedLoaderClassPath.java 28.00% <0.00%> (-16.00%) 0.00% <0.00%> (ø%)
... and 230 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34b744b...f247237. Read the comment docs.

Copy link
Contributor

@kevinw66 kevinw66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit 161380c into apache:master May 16, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants