-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
About the application of spring management repeated monitoring processing dubbo shutdown. #7317
Conversation
…onitoring processing dubbo shutdown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Codecov Report
@@ Coverage Diff @@
## master #7317 +/- ##
============================================
+ Coverage 59.03% 59.16% +0.13%
- Complexity 462 528 +66
============================================
Files 1044 1077 +33
Lines 42472 43566 +1094
Branches 6227 6368 +141
============================================
+ Hits 25074 25777 +703
- Misses 14594 14925 +331
- Partials 2804 2864 +60 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is the purpose of the change
Solve the repeated monitoring of applications managed by spring
see more detail from #7093
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.