Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 8292 #8340

Closed
wants to merge 1 commit into from
Closed

fix issue 8292 #8340

wants to merge 1 commit into from

Conversation

hengyoush
Copy link
Contributor

What is the purpose of the change

fix #8292

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2021

Codecov Report

Merging #8340 (30eea81) into master (352a0df) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8340      +/-   ##
============================================
- Coverage     61.29%   61.27%   -0.02%     
- Complexity      446      447       +1     
============================================
  Files          1096     1096              
  Lines         44212    44213       +1     
  Branches       6445     6445              
============================================
- Hits          27099    27092       -7     
- Misses        14136    14147      +11     
+ Partials       2977     2974       -3     
Impacted Files Coverage Δ
.../dubbo/registry/integration/RegistryDirectory.java 76.26% <100.00%> (+0.09%) ⬆️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 80.34% <0.00%> (-6.84%) ⬇️
...he/dubbo/remoting/transport/netty/NettyHelper.java 35.48% <0.00%> (-6.46%) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 62.37% <0.00%> (-1.99%) ⬇️
...e/dubbo/remoting/transport/netty4/NettyClient.java 69.56% <0.00%> (-1.45%) ⬇️
...he/dubbo/registry/multicast/MulticastRegistry.java 67.44% <0.00%> (-0.94%) ⬇️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 79.72% <0.00%> (-0.35%) ⬇️
.../java/org/apache/dubbo/config/ReferenceConfig.java 70.44% <0.00%> (+0.49%) ⬆️
...pache/dubbo/remoting/transport/AbstractServer.java 62.85% <0.00%> (+1.42%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 352a0df...30eea81. Read the comment docs.

@chickenlj
Copy link
Contributor

Resolved in #9147

@chickenlj chickenlj closed this Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants