Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

[EAGLE-985] Upgrade hbase dependency to 1.2.5 #902

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tedyu
Copy link

@tedyu tedyu commented Apr 3, 2017

Upgrade hbase dependency to 1.2.5

@jhsenjaliya
Copy link
Contributor

+1, LGTM, I will be testing this on my dev environment as well sometime tomorrow.

@qingwen220
Copy link
Contributor

@jhsenjaliya @tedyu After this upgrade, does we still support HBase 0.98?

@jhsenjaliya
Copy link
Contributor

Hi @qingwen220 no, since there are some function signature changes here, I dont think it will be compatible. ( without those changes, it is compatible though) so the question really comes down to whether we want to support 0.98 till 0.5 release then this can be pushed to 0.6 when majority of the tech stack is going to change ( storm, kafka, etc..), comment?

@qingwen220
Copy link
Contributor

Yes. We expect after 0.5, Eagle can support Kafka 0.10 & storm 0.10.

There is a concern. We have a coprocessor module in Eagle for HBase 0.98. I am not sure if we could support this function after upgrade

@wujinhu
Copy link
Contributor

wujinhu commented Apr 5, 2017

Should we have multiple version support for HBase(Storm/Kafka etc) so that users can still use old versions if they cannot switch to new version quickly?
I think it will be better if we have some abstractions first instead of doing like this.

@r7raul1984
Copy link

@wujinhu +1

@r7raul1984
Copy link

r7raul1984 commented Apr 6, 2017

In my opition ,we should do more test before upgrade to hbase 1.2.5 rather than just solve compile problem.

@jhsenjaliya
Copy link
Contributor

master works fine with hbase 1.2.2
I am planning to test this patch with hbase 1.2.5 tonight

@baibaichen
Copy link
Contributor

hi @tedyu

Is the new API you used supported in 1.0.x?

@tedyu
Copy link
Author

tedyu commented Apr 7, 2017

Yes. But hbase 1.0 wouldn't have any more new release.

@tedyu
Copy link
Author

tedyu commented Apr 14, 2017

@jhsenjaliya
Did you find any issue during testing ?

@jhsenjaliya
Copy link
Contributor

@tedyu I pulled your PR and used ur code to run my eagle, I am running alert engine app + hdfs audit log app and it successfully created the alert i was expecting. so this PR is working fine. but As i mentioned earlier, I was using hbase 1.2.2 and also tested hbase 1.2.5 without any code change to eagle and it was working fine as well. so probably these changes are not mandatory but good to follow newer hbase functions.

@jhsenjaliya
Copy link
Contributor

@qingwen220 , @r7raul1984 looks like we can accommodate hbase 1.2.5 with or without this PR changes but I havent tested with hbase coprocessor enabled. so if someone can test current eagle code with hbase 1.2.5 with coprocessor enabled, we can make decision on whether we can include hbase upgrade in eagle 0.5 or later.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants