Skip to content

Conversation

melin
Copy link

@melin melin commented Aug 14, 2024

No description provided.

@yuxiqian
Copy link
Member

Hi @melin, seems the error log message you want to emit is Handling schema request in SchemaRegistry, which will be printed when an schema lookup request occurs. Changing it to DEBUG level is reasonable.

However, the log you've just modified will be printed only once for CreateTableEvents, which is significant and should not be classified to DEBUG level.

Maybe the log code you want to change is

LOG.info("Handling evolved schema request: {}", getEvolvedSchemaRequest);

and

LOG.info("Handling original schema request: {}", getOriginalSchemaRequest);

in SchemaRegistry.java?

"Unable to apply CreateTableEvent to an existing schema for table \"%s\"",
event.tableId());
LOG.info("Handling schema change event: {}", event);
LOG.debug("Handling schema change event: {}", event);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this is not the text that floods your output log.

Copy link
Member

@yuxiqian yuxiqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for @melin's work, changes look reasonable to me.

Copy link

This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Oct 22, 2024
Copy link

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.

@github-actions github-actions bot closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants