-
Notifications
You must be signed in to change notification settings - Fork 492
[FLINK-27303][FLINK-27309] Introduce FlinkConfigManager for efficient config management #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just a quick note: instead of creating a watch on the ConfigMap, I prefer to simply use |
Makes sense @wangyang0918 thats a simple change to make it more robust |
Reworked the watcher logic and added some more tests |
...s-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java
Outdated
Show resolved
Hide resolved
...s-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java
Outdated
Show resolved
Hide resolved
...s-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigManager.java
Outdated
Show resolved
Hide resolved
c12d32a
to
153dc8c
Compare
...s-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigManager.java
Show resolved
Hide resolved
...s-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
This PR improves/reworks the configuration management of the oprator. Problems with the current approach:
To try to tackle all these problems at once I have introduced the
FlinkConfigManager
object which is responsible for:While these changes touch almost all components, it is mostly cosmetic. The core improvements are located in the
FlinkConfigManager
class and which config is requested in the different parts of the reconcile logic.