Use github actions for flink-kubernetes-operator CI #4
Conversation
wangyang0918
force-pushed
the
ci
branch
3 times, most recently
from
1070eca to
0bec47e
Compare
|
The CI has been successfully run my personal actions. It will take effect as soon as we merge this PR. https://github.com/wangyang0918/flink-kubernetes-operator/actions/runs/1856555659 cc @gyfora |
.github/workflows/ci.yml
Outdated
| export SHELL=/bin/bash | ||
| export DOCKER_BUILDKIT=1 | ||
| eval $(minikube -p minikube docker-env) | ||
| docker build -f ./Dockerfile -t flink-java-operator:ci-latest . |
There was a problem hiding this comment.
nit: we could probably use the flink-kubernetes-operator name here too
.github/workflows/ci.yml
Outdated
| docker images | ||
| - name: Start the operator | ||
| run: | | ||
| helm install flink-operator helm/flink-operator --set image.repository=flink-java-operator --set image.tag=ci-latest |
There was a problem hiding this comment.
nit: we could probably use the flink-kubernetes-operator name here too
.github/workflows/ci.yml
Outdated
| export SHELL=/bin/bash | ||
| export DOCKER_BUILDKIT=1 | ||
| eval $(minikube -p minikube docker-env) | ||
| docker build -f ./Dockerfile -t flink-java-operator:ci-latest . |
There was a problem hiding this comment.
nit: we could probably use the flink-kubernetes-operator name here too
.github/workflows/ci.yml
Outdated
| docker images | ||
| - name: Start the operator | ||
| run: | | ||
| helm install flink-operator helm/flink-operator --set image.repository=flink-java-operator --set image.tag=ci-latest |
There was a problem hiding this comment.
nit: we could probably use the flink-kubernetes-operator name here too
|
Hi @wangyang0918! This looks great, I like the light-weight approach of using GitHub actions. As far as I understand this solution is also free as this is a public repo with moderate load (for the time being). @tisonkun I like publishing the docker images when the CI succeeds (with some rolling tagging policy) and obviously with stable tags on releases. I prefer having these images on DockerHub similarly to the flink repository there. I think this merits its own ticket and a bit of discussion on technical details, would you be so kind to open a ticket under FLINK-25963? |
|
@mbalassi thanks for your reply! Created at https://issues.apache.org/jira/browse/FLINK-26214. We can discuss in details there. |
|
cc @mbalassi I have addressed the comments. Please have another look. |
|
@wangyang0918 thanks for contributing this! Will there any indicator on the PR itself whether the CI has passed or not? |
This PR tries to use the github actions for the CI. We have the following two jobs.
test_kubernetes_application_ha.shwill start a Flink application with HA enabled. Wait for successful checkpoints and then kill the JobManager to verify the restoring.