-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-14878]Support use catalog
through sqlUpdate() method in TableEnvironment
#10272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @bowenli86 @xuefuz @lirui-apache @KurtYoung to have a review. |
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit ea05725 (Wed Nov 20 18:07:42 UTC 2019) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM mostly with some questions left
public class SqlUseCatalog extends SqlCall { | ||
|
||
public static final SqlSpecialOperator OPERATOR = new SqlSpecialOperator("USE CATALOG", SqlKind.OTHER); | ||
public static final SqlSpecialOperator OPERATOR = new SqlSpecialOperator("USE CATALOG", SqlKind.OTHER_DDL); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both validate(sqlNode: SqlNode)
methods in FlinkPlannerImpl
in flink-planner/blink-planner will validate row type, SqlKind.OTHER kind will fail the validation.
...k-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
Outdated
Show resolved
Hide resolved
...e/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ddl/UseOperation.java
Outdated
Show resolved
Hide resolved
...e/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ddl/UseOperation.java
Outdated
Show resolved
Hide resolved
...le/flink-table-planner/src/main/scala/org/apache/flink/table/api/internal/TableEnvImpl.scala
Show resolved
Hide resolved
1.Update exception info 2.Revert unrelated change of style
f60d47c
to
efe214d
Compare
sorry for the late comment, but I happened to notice that UseCatalogOperation and UseOperation reside in package |
Make sense, addressed. |
What is the purpose of the change
Support
USE CATALOG catalogName
throughsqlUpdate()
method in TableEnvironmentBrief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation