-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-2751] [Documentation] Add quickstart menu to the navigation bar #1176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @rerngvit, Thanks for sending pull request. But your pull request has some problems. First, Second, there is no conditional |
1. Define {{quick_start}} 2. Define active class for {{quick_start}} Dropdown menu
@chiwanpark Thanks for reviewing this issue. I modified the pull request according to your comments. Please have a look. |
Hi @rerngvit, I have tested your pull request. Because <li class="dropdown{% if page.url contains '/quickstart/' %} active{% endif %}"> The solution must be applied not only quickstart but also other dropdown menus such as setup, programming guide, ..., etc.. BTW, there is a typo line 68 of After addressing this, we can merge this pull request. :-) |
1. Add '/{link_name}/' for all dropDown toggle condition checks 2. Fix closing tag in line 68 (JobManager High Availability)
@chiwanpark Thanks for reviewing this issue. I revised the pull request according to your comments. Please have a look. |
Looks good to merge. I'll merge this. |
…mentation - Improve conditional "active" class for dropdown menu - Fix unclosed A tag This closes apache#1176.
Looks good. Thanks for the contribution @rerngvit! |
…mentation - Improve conditional "active" class for dropdown menu - Fix unclosed A tag This closes apache#1176.
…mentation - Improve conditional "active" class for dropdown menu - Fix unclosed A tag This closes apache#1176.
…mentation - Improve conditional "active" class for dropdown menu - Fix unclosed A tag This closes apache#1176.
Add quickstart menu to the navigation bar for Flink documentation