-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-2901] Remove Record API dependencies from flink-tests #1306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Nice @zentol! Thanks for this effort! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep this test and port it.
Hi @zentol, thanks again for the huge effort to port all these tests! Looks mostly good, except for some minor things and three tests which should be ported to preserve test coverage, IMO. |
@fhueske I've addressed most of your concerns. Things that still need work / clarification:
|
Hi @zentol, sorry for the delayed review. However, I do not think that the @zentol Is it OK for you if I add this one last test and merge this PR afterwards? |
Go ahead, i won't have time for it today anyway :) |
Thanks, I'll port the last test and merge this PR |
This PR removes all dependencies to the Record API in the flink-tests project.
For this, tests were either ported or removed.
The following files were NOT ported:
cancelling/MatchJoinCancellingITCase was ported but disabled since it is unstable, and also disabled before. Separate issue seems appropriate.