-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[Flink-22974] Add execution checkpointing configs in flink-conf.yaml #16147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There is no parameter description for execution checkpointing in flink-conf.yaml. It may cause a misunderstanding. I think we can add some important parameters, such as execution.checkpointing.interval,execution.checkpointing.externalized-checkpoint-retention,execution.checkpointing.tolerable-failed-checkpoints etc.
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit d476305 (Sat Aug 28 12:17:37 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tinawenqiao , thanks for your contribution.
Please refine your description of this PR and take a look at my comments.
BTW, please rename your commit message with the prefix as |
@tinawenqiao thanks for your update! |
@tinawenqiao I’m afraid that you still did not get what I mean. You could refer to this doc to know how to combine your commits into one. Once I merge this PR into master branch, there should only exists one commit for this PR in the last. |
A new pr is submit here. Please revew the new pr. #16183 |
To be honest, there is no need to create another PR, you could update this PR with force pushing. I'll close this PR now. |
There is no parameter description for execution checkpointing in flink-conf.yaml. It may cause a misunderstanding. I think we can add some important parameters, such as
execution.checkpointing.interval,execution.checkpointing.externalized-checkpoint-retention,execution.checkpointing.tolerable-failed-checkpoints etc.
What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation