Skip to content

Conversation

tinawenqiao
Copy link
Contributor

There is no parameter description for execution checkpointing in flink-conf.yaml. It may cause a misunderstanding. I think we can add some important parameters, such as
execution.checkpointing.interval,execution.checkpointing.externalized-checkpoint-retention,execution.checkpointing.tolerable-failed-checkpoints etc.

What is the purpose of the change

(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)

Brief change log

(for example:)

  • The TaskInfo is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

There is no parameter description for execution checkpointing in flink-conf.yaml. It may cause a misunderstanding.  I think we can add some important parameters, such as 
execution.checkpointing.interval,execution.checkpointing.externalized-checkpoint-retention,execution.checkpointing.tolerable-failed-checkpoints etc.
@flinkbot
Copy link
Collaborator

flinkbot commented Jun 11, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit d476305 (Sat Aug 28 12:17:37 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 11, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@Myasuka Myasuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tinawenqiao , thanks for your contribution.
Please refine your description of this PR and take a look at my comments.

@Myasuka
Copy link
Member

Myasuka commented Jun 17, 2021

BTW, please rename your commit message with the prefix as [FLINK-22974][dist], you can force push your commits to update this PR.

@Myasuka
Copy link
Member

Myasuka commented Jun 17, 2021

@tinawenqiao thanks for your update!
Actually, what I mean "force push" is hoping you could squash your commits into one and then force push to your target branch, so that I could easily merge this PR to master.

@Myasuka
Copy link
Member

Myasuka commented Jun 17, 2021

@tinawenqiao I’m afraid that you still did not get what I mean. You could refer to this doc to know how to combine your commits into one. Once I merge this PR into master branch, there should only exists one commit for this PR in the last.
BTW, please modify your descriptions of this PR to remove those default template content.

@tinawenqiao
Copy link
Contributor Author

tinawenqiao commented Jun 17, 2021

@tinawenqiao thanks for your update!
Actually, what I mean "force push" is hoping you could squash your commits into one and then force push to your target branch, so that I could easily merge this PR to master.

A new pr is submit here. Please revew the new pr. #16183

@Myasuka
Copy link
Member

Myasuka commented Jun 17, 2021

To be honest, there is no need to create another PR, you could update this PR with force pushing.

I'll close this PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants