[FLINK-23030][network] PartitionRequestClientFactory#createPartitionRequestClient should throw when network failure

[jinxing64]

What is the purpose of the change

In current PartitionRequestClientFactory#createPartitionRequestClient, ChannelFuture#await() is invoked, thus to build a connection to remote synchronously.

But with the doc of io.netty.util.concurrent.Future[1] and its implementation io.netty.channel.DefaultChannelPromise[2], ChannelFuture#await() never throws when completed with failure. I guess what Flink needs is ChannelFuture#sync().

[1] https://netty.io/4.1/api/io/netty/util/concurrent/class-use/Future.html
[2] https://github.com/netty/netty/blob/4.1/transport/src/main/java/io/netty/channel/DefaultChannelPromise.java
https://github.com/netty/netty/blob/4.1/common/src/main/java/io/netty/util/concurrent/DefaultPromise.java

Brief change log

• Replace ChannelFuture#await with ChannelFuture#sync in PartitionRequestClientFactory#connect
• Removed some unused codes in PartitionRequestClientFactoryTest

Verifying this change

Added test PartitionRequestClientFactoryTest#testThrowsWhenNetworkFailure

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
• The serializers: (no)
• The runtime per-record code paths (performance sensitive): (no)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
• The S3 file system connector: (no)

Documentation

• Does this pull request introduce a new feature? (no)
• If yes, how is the feature documented? (not applicable)

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 70e0c8d (Thu Sep 23 17:27:32 UTC 2021)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• 70e0c8d Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run travis re-run the last Travis build
• @flinkbot run azure re-run the last Azure build

[pnowojski]

Nice catch! Thanks for reporting and fixing the problem.

[jinxing64]

Thanks a lot for merging ~