Skip to content

[BP-1.13][FLINK-23045][tests] Harden RunnablesTest by not relying on timeout #16262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 25, 2021
Merged

[BP-1.13][FLINK-23045][tests] Harden RunnablesTest by not relying on timeout #16262

merged 3 commits into from
Jun 25, 2021

Conversation

tillrohrmann
Copy link
Contributor

Backport of #16261 to release-1.13.

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 23, 2021 •
edited
Loading

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit ad1e457 (Thu Sep 23 17:51:22 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 23, 2021 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@tillrohrmann
Copy link
Contributor Author

Thanks for the review @rmetzger. Merging this PR now.

@tillrohrmann
[hotfix] Let RunnablesTest extend TestLogger
fe5f2d1
@tillrohrmann
[FLINK-23045][tests] Harden RunnablesTest by not relying on timeout
d9121d7 
This commit hardens the RunnablesTest.testExecutorService_uncaughtExceptionHandler to not rely
on timeouts to check whether the uncaught exception handler was called.

This closes apache#16262.
@tillrohrmann
[hotfix][tests] Correct variable name in RunnablesTest.testExecutorSe…
ad1e457 
…rvice_uncaughtExceptionHandler
@tillrohrmann tillrohrmann merged commit ad1e457 into apache:release-1.13 Jun 25, 2021
@tillrohrmann tillrohrmann deleted the FLINK-23045-113 branch June 25, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmetzger rmetzger rmetzger approved these changes

Assignees
No one assigned
Labels
component=Runtime/Coordination review=description?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tillrohrmann @flinkbot @rmetzger