Skip to content

Conversation

tillrohrmann
Copy link
Contributor

@tillrohrmann tillrohrmann commented Aug 28, 2021

Backport of #17033 to release-1.14.

@tillrohrmann tillrohrmann changed the title [FLINK-23947] Improve logging of granting/revoking leadership in DefaultDispatcherRunner [BP-1.14][FLINK-23947] Improve logging of granting/revoking leadership in DefaultDispatcherRunner Aug 28, 2021
@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 5156744 (Sat Aug 28 18:12:52 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 28, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@tillrohrmann
Copy link
Contributor Author

Merging this PR now.

…ultDispatcherRunner

This commit logs on info level when the DefaultDispatcherRunner was granted or revoked its leadership.
@tillrohrmann tillrohrmann merged commit dfa1613 into apache:release-1.14 Aug 30, 2021
@tillrohrmann tillrohrmann deleted the FLINK-23947-114 branch August 30, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants