Skip to content

[FLINK-3560] [examples] Remove unchecked output of usage statement in examples #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[FLINK-3560] [examples] Remove unchecked output of usage statement in examples #1752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .../flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ public static void main(String[] args) throws Exception {

// Checking input parameters
final ParameterTool params = ParameterTool.fromArgs(args);
System.out.println("Usage: KMeans --points <path> --centroids <path> --output <path> --iterations <n>");

// set up execution environment
ExecutionEnvironment env = ExecutionEnvironment.getExecutionEnvironment();
Expand Down
4 changes: 2 additions & 2 deletions ...ples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/distcp/DistCp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,8 @@ public static void main(String[] args) throws Exception {


FlatMapOperator<FileCopyTask, Object> res = inputTasks.flatMap(new RichFlatMapFunction<FileCopyTask, Object>() {


private static final long serialVersionUID = 1109254230243989929L;
private LongCounter fileCounter;
private LongCounter bytesCounter;

Expand Down Expand Up @@ -185,5 +186,4 @@ private static void getCopyTasks(Path p, String rel, List<FileCopyTask> tasks) t
}
}
}

}
11 changes: 1 addition & 10 deletions ...xamples-batch/src/main/java/org/apache/flink/examples/java/graph/ConnectedComponents.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

package org.apache.flink.examples.java.graph;

import org.apache.flink.api.common.ProgramDescription;
import org.apache.flink.api.common.functions.FlatJoinFunction;
import org.apache.flink.api.common.functions.FlatMapFunction;
import org.apache.flink.api.common.functions.JoinFunction;
Expand Down Expand Up @@ -74,7 +73,7 @@
* </ul>
*/
@SuppressWarnings("serial")
public class ConnectedComponents implements ProgramDescription {
public class ConnectedComponents {

// *************************************************************************
// PROGRAM
Expand All @@ -84,7 +83,6 @@ public static void main(String... args) throws Exception {

// Checking input parameters
final ParameterTool params = ParameterTool.fromArgs(args);
System.out.println("Usage: ConnectedComponents --vertices <path> --edges <path> --output <path> --iterations <n>");

// set up execution environment
ExecutionEnvironment env = ExecutionEnvironment.getExecutionEnvironment();
Expand Down Expand Up @@ -185,13 +183,6 @@ public void join(Tuple2<Long, Long> candidate, Tuple2<Long, Long> old, Collector
}
}



@Override
public String getDescription() {
return "Parameters: --vertices <path> --edges <path> --output <path> --iterations <n>";
}

// *************************************************************************
// UTIL METHODS
// *************************************************************************
Expand Down
3 changes: 1 addition & 2 deletions ...link-examples-batch/src/main/java/org/apache/flink/examples/java/graph/EnumTriangles.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ public static void main(String[] args) throws Exception {

// Checking input parameters
final ParameterTool params = ParameterTool.fromArgs(args);
System.out.println("Usage: EnumTriangleBasic --edges <path> --output <path>");

// set up execution environment
final ExecutionEnvironment env = ExecutionEnvironment.getExecutionEnvironment();
Expand Down Expand Up @@ -124,7 +123,7 @@ public static void main(String[] args) throws Exception {
triangles.print();
}
}

// *************************************************************************
// USER FUNCTIONS
// *************************************************************************
Expand Down
11 changes: 5 additions & 6 deletions ...les/flink-examples-batch/src/main/java/org/apache/flink/examples/java/graph/PageRank.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ public class PageRank {
public static void main(String[] args) throws Exception {

ParameterTool params = ParameterTool.fromArgs(args);
System.out.println("Usage: PageRankBasic --pages <path> --links <path> --output <path> --numPages <n> --iterations <n>");

final int numPages = params.getInt("numPages", PageRankData.getNumberOfPages());
final int maxIterations = params.getInt("iterations", 10);
Expand Down Expand Up @@ -135,7 +134,7 @@ public static void main(String[] args) throws Exception {


}

// *************************************************************************
// USER FUNCTIONS
// *************************************************************************
Expand All @@ -147,7 +146,7 @@ public static final class RankAssigner implements MapFunction<Long, Tuple2<Long,
Tuple2<Long, Double> outPageWithRank;

public RankAssigner(double rank) {
this.outPageWithRank = new Tuple2<Long, Double>(-1l, rank);
this.outPageWithRank = new Tuple2<Long, Double>(-1L, rank);
}

@Override
Expand Down Expand Up @@ -189,9 +188,9 @@ public void flatMap(Tuple2<Tuple2<Long, Double>, Tuple2<Long, Long[]>> value, Co
Long[] neighbors = value.f1.f1;
double rank = value.f0.f1;
double rankToDistribute = rank / ((double) neighbors.length);
for (int i = 0; i < neighbors.length; i++) {
out.collect(new Tuple2<Long, Double>(neighbors[i], rankToDistribute));

for (Long neighbor: neighbors) {
out.collect(new Tuple2<Long, Double>(neighbor, rankToDistribute));
}
}
}
Expand Down
10 changes: 1 addition & 9 deletions ...ples-batch/src/main/java/org/apache/flink/examples/java/graph/TransitiveClosureNaive.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

package org.apache.flink.examples.java.graph;

import org.apache.flink.api.common.ProgramDescription;
import org.apache.flink.api.common.functions.CoGroupFunction;
import org.apache.flink.api.common.functions.GroupReduceFunction;
import org.apache.flink.api.common.functions.JoinFunction;
Expand All @@ -34,13 +33,12 @@
import java.util.Set;

@SuppressWarnings("serial")
public class TransitiveClosureNaive implements ProgramDescription {
public class TransitiveClosureNaive {

public static void main (String... args) throws Exception {

// Checking input parameters
final ParameterTool params = ParameterTool.fromArgs(args);
System.out.println("Usage: TransitiveClosure --edges <path> --output <path> --iterations <n>");

// set up execution environment
ExecutionEnvironment env = ExecutionEnvironment.getExecutionEnvironment();
Expand Down Expand Up @@ -117,10 +115,4 @@ public void coGroup(Iterable<Tuple2<Long, Long>> prevPaths, Iterable<Tuple2<Long
transitiveClosure.print();
}
}

@Override
public String getDescription() {
return "Parameters: --edges <path> --output <path> --iterations <n>";
}

}
1 change: 0 additions & 1 deletion ...link-examples-batch/src/main/java/org/apache/flink/examples/java/ml/LinearRegression.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ public class LinearRegression {
public static void main(String[] args) throws Exception {

final ParameterTool params = ParameterTool.fromArgs(args);
System.out.println("Usage: LinearRegression --input <path> --output <path> --iterations <n>");

// set up execution environment
final ExecutionEnvironment env = ExecutionEnvironment.getExecutionEnvironment();
Expand Down
1 change: 0 additions & 1 deletion .../src/main/java/org/apache/flink/examples/java/relational/EmptyFieldsCountAccumulator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ public static void main(final String[] args) throws Exception {
final ParameterTool params = ParameterTool.fromArgs(args);

final ExecutionEnvironment env = ExecutionEnvironment.getExecutionEnvironment();
System.out.println("Usage: EmptyFieldsCountAccumulator --input <path> --output <path>");

// make parameters available in the web interface
env.getConfig().setGlobalJobParameters(params);
Expand Down
1 change: 0 additions & 1 deletion ...k-examples-batch/src/main/java/org/apache/flink/examples/java/relational/TPCHQuery10.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,5 +216,4 @@ private static DataSet<Tuple2<Integer, String>> getNationsDataSet(ExecutionEnvir
.includeFields("1100")
.types(Integer.class, String.class);
}

}
2 changes: 1 addition & 1 deletion ...nk-examples-batch/src/main/java/org/apache/flink/examples/java/relational/TPCHQuery3.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ public ShippingPriorityItem join(ShippingPriorityItem i, Lineitem l) {
}

}

// *************************************************************************
// DATA TYPES
// *************************************************************************
Expand Down
3 changes: 1 addition & 2 deletions ...xamples-batch/src/main/java/org/apache/flink/examples/java/relational/WebLogAnalysis.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ public static void main(String[] args) throws Exception {
final ParameterTool params = ParameterTool.fromArgs(args);

final ExecutionEnvironment env = ExecutionEnvironment.getExecutionEnvironment();
System.out.println("Usage: WebLogAnalysis --documents <path> --ranks <path> --visits <path> --output <path>");

env.getConfig().setGlobalJobParameters(params);

Expand Down Expand Up @@ -147,7 +146,7 @@ public static void main(String[] args) throws Exception {
result.print();
}
}

// *************************************************************************
// USER FUNCTIONS
// *************************************************************************
Expand Down
3 changes: 1 addition & 2 deletions ...link-examples-batch/src/main/java/org/apache/flink/examples/java/wordcount/WordCount.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ public static void main(String[] args) throws Exception {

// make parameters available in the web interface
env.getConfig().setGlobalJobParameters(params);
System.out.println("Usage: WordCount --input <path> --output <path>");

// get input data
DataSet<String> text;
Expand Down Expand Up @@ -94,7 +93,7 @@ public static void main(String[] args) throws Exception {
}

}

// *************************************************************************
// USER FUNCTIONS
// *************************************************************************
Expand Down
2 changes: 0 additions & 2 deletions ...ink-examples-batch/src/main/scala/org/apache/flink/examples/scala/clustering/KMeans.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ object KMeans {

// checking input parameters
val params: ParameterTool = ParameterTool.fromArgs(args)
println("Usage: KMeans --points <path> --centroids <path> --output <path> --iterations <n>")

// set up execution environment
val env: ExecutionEnvironment = ExecutionEnvironment.getExecutionEnvironment
Expand Down Expand Up @@ -225,7 +224,6 @@ object KMeans {
}

}

}


3 changes: 0 additions & 3 deletions ...ples-batch/src/main/scala/org/apache/flink/examples/scala/graph/ConnectedComponents.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@ object ConnectedComponents {
def main(args: Array[String]) {

val params: ParameterTool = ParameterTool.fromArgs(args)
println("Usage: ConnectedComponents " +
"--vertices <path> --edges <path> --output <path> --iterations <n>")

// set up execution environment
val env = ExecutionEnvironment.getExecutionEnvironment
Expand Down Expand Up @@ -151,5 +149,4 @@ object ConnectedComponents {
env.fromCollection(edgeData)
}
}

}
2 changes: 0 additions & 2 deletions ...k-examples-batch/src/main/scala/org/apache/flink/examples/scala/graph/EnumTriangles.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ object EnumTriangles {
def main(args: Array[String]) {

val params: ParameterTool = ParameterTool.fromArgs(args)
println("Usage: EnumTriangleBasic --edges <path> --output <path>")

// set up execution environment
val env = ExecutionEnvironment.getExecutionEnvironment
Expand Down Expand Up @@ -156,5 +155,4 @@ object EnumTriangles {
}
}
}

}
3 changes: 0 additions & 3 deletions ...k-examples-batch/src/main/scala/org/apache/flink/examples/scala/graph/PageRankBasic.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,6 @@ object PageRankBasic {
def main(args: Array[String]) {

val params: ParameterTool = ParameterTool.fromArgs(args)
println("Usage: PageRankBasic " +
"--pages <path> --links <path> --output <path> --numPages <n> --iterations <n>")

// set up execution environment
val env = ExecutionEnvironment.getExecutionEnvironment
Expand Down Expand Up @@ -183,5 +181,4 @@ object PageRankBasic {
env.fromCollection(edges)
}
}

}
4 changes: 1 addition & 3 deletions ...s-batch/src/main/scala/org/apache/flink/examples/scala/graph/TransitiveClosureNaive.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,11 @@ import org.apache.flink.api.scala._
import org.apache.flink.examples.java.graph.util.ConnectedComponentsData
import org.apache.flink.util.Collector

object TransitiveClosureNaive {
object TransitiveClosureNaive {

def main (args: Array[String]): Unit = {

val params: ParameterTool = ParameterTool.fromArgs(args)
println("Usage: TransitiveClosure --edges <path> --output <path> --iterations <n>")

// set up execution environment
val env = ExecutionEnvironment.getExecutionEnvironment
Expand Down Expand Up @@ -86,5 +85,4 @@ object TransitiveClosureNaive {
}

}

}
2 changes: 0 additions & 2 deletions ...k-examples-batch/src/main/scala/org/apache/flink/examples/scala/ml/LinearRegression.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ object LinearRegression {
def main(args: Array[String]) {

val params: ParameterTool = ParameterTool.fromArgs(args)
println("Usage: LinearRegression --input <path> --output <path> --iterations <n>")

// set up execution environment
val env = ExecutionEnvironment.getExecutionEnvironment
Expand Down Expand Up @@ -157,5 +156,4 @@ object LinearRegression {
(Params(theta0, theta1), 1)
}
}

}
1 change: 0 additions & 1 deletion ...xamples-batch/src/main/scala/org/apache/flink/examples/scala/relational/TPCHQuery10.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,5 +175,4 @@ object TPCHQuery10 {
fieldDelimiter = "|",
includedFields = Array(0, 1) )
}

}
1 change: 0 additions & 1 deletion ...examples-batch/src/main/scala/org/apache/flink/examples/scala/relational/TPCHQuery3.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,5 +169,4 @@ object TPCHQuery3 {
fieldDelimiter = "|",
includedFields = Array(0, 1, 4, 7) )
}

}
1 change: 0 additions & 1 deletion ...ples-batch/src/main/scala/org/apache/flink/examples/scala/relational/WebLogAnalysis.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ object WebLogAnalysis {
def main(args: Array[String]) {

val params: ParameterTool = ParameterTool.fromArgs(args)
println("Usage: --documents <path> --ranks <path> --visits <path> --output <path>")

// set up execution environment
val env = ExecutionEnvironment.getExecutionEnvironment
Expand Down
2 changes: 0 additions & 2 deletions ...k-examples-batch/src/main/scala/org/apache/flink/examples/scala/wordcount/WordCount.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ object WordCount {
def main(args: Array[String]) {

val params: ParameterTool = ParameterTool.fromArgs(args)
System.out.println("Usage: WordCount --input <path> --output <path>")

// set up execution environment
val env = ExecutionEnvironment.getExecutionEnvironment
Expand Down Expand Up @@ -78,7 +77,6 @@ object WordCount {
}

}

}


1 change: 0 additions & 1 deletion ...streaming/src/main/java/org/apache/flink/streaming/examples/iteration/IterateExample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ public static void main(String[] args) throws Exception {

// Checking input parameters
final ParameterTool params = ParameterTool.fromArgs(args);
System.out.println(" Usage: IterateExample --input <path> --output <path>");

// set up input for the stream of integer pairs

Expand Down
1 change: 1 addition & 0 deletions ...les-streaming/src/main/java/org/apache/flink/streaming/examples/kafka/WriteIntoKafka.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ public static void main(String[] args) throws Exception {

// very simple data generator
DataStream<String> messageStream = env.addSource(new SourceFunction<String>() {
private static final long serialVersionUID = 6369260445318862378L;
public boolean running = true;

@Override
Expand Down
1 change: 0 additions & 1 deletion ...ing/src/main/java/org/apache/flink/streaming/examples/ml/IncrementalLearningSkeleton.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ public static void main(String[] args) throws Exception {

// Checking input parameters
final ParameterTool params = ParameterTool.fromArgs(args);
System.out.println("Usage: IncrementalLearningSkeleton --output <path>");

StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
env.setStreamTimeCharacteristic(TimeCharacteristic.EventTime);
Expand Down
1 change: 0 additions & 1 deletion ...reaming/src/main/java/org/apache/flink/streaming/examples/windowing/SessionWindowing.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ public static void main(String[] args) throws Exception {

final ParameterTool params = ParameterTool.fromArgs(args);
final StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
System.out.println("Usage: SessionWindowing --output <path>");

env.getConfig().setGlobalJobParameters(params);
env.setStreamTimeCharacteristic(TimeCharacteristic.EventTime);
Expand Down
1 change: 0 additions & 1 deletion ...eaming/src/main/java/org/apache/flink/streaming/examples/windowing/TopSpeedWindowing.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ public class TopSpeedWindowing {
public static void main(String[] args) throws Exception {

final ParameterTool params = ParameterTool.fromArgs(args);
System.err.println("Usage: TopSpeedWindowingExample --input <path> --output <path>");

final StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
env.setStreamTimeCharacteristic(TimeCharacteristic.EventTime);
Expand Down
Loading