Skip to content

Conversation

MartijnVisser
Copy link
Contributor

@MartijnVisser MartijnVisser commented Dec 27, 2021

What is the purpose of the change

  • Updating net.sf.py4j:py4j from 0.10.8.1 to 0.10.9.3

Brief change log

  • Updated POM, Python dev requirements & setup, NOTICE file

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): yes
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 27, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 91439cd (Mon Dec 27 13:50:16 UTC 2021)

Warnings:

  • 1 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • Invalid pull request title: No valid Jira ID provided

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@MartijnVisser MartijnVisser changed the title [FLINK-XXXXX][python] Update net.sf.py4j:py4j dependency to 0.10.8.1 [FLINK-25461][python] Update net.sf.py4j:py4j dependency to 0.10.8.1 Dec 27, 2021
@MartijnVisser MartijnVisser changed the title [FLINK-25461][python] Update net.sf.py4j:py4j dependency to 0.10.8.1 [FLINK-25461][python] Update net.sf.py4j:py4j dependency to 0.10.9.3 Dec 27, 2021
@MartijnVisser MartijnVisser marked this pull request as ready for review December 27, 2021 14:46
@MartijnVisser
Copy link
Contributor Author

@flinkbot run azure

2 similar comments
@MartijnVisser
Copy link
Contributor Author

@flinkbot run azure

@MartijnVisser
Copy link
Contributor Author

@flinkbot run azure

@MartijnVisser
Copy link
Contributor Author

@HuangXingBo Do you want to take a look?

@dianfu
Copy link
Contributor

dianfu commented Dec 31, 2021

@flinkbot run azure

Copy link
Contributor

@dianfu dianfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MartijnVisser Thanks a lot for the PR. LGTM.

@dianfu
Copy link
Contributor

dianfu commented Dec 31, 2021

@MartijnVisser Oh, just missed that the source package for Py4J should also be updated: https://github.com/apache/flink/tree/master/flink-python/lib/

@MartijnVisser MartijnVisser force-pushed the lcm/net.sf.py4j branch 2 times, most recently from 83624f3 to 2a277d7 Compare December 31, 2021 08:13
@MartijnVisser
Copy link
Contributor Author

@MartijnVisser Oh, just missed that the source package for Py4J should also be updated: https://github.com/apache/flink/tree/master/flink-python/lib/

Thanks for that @dianfu - I've updated the PR. Should it be mentioned in the README that this needs to be done? I only just saw it in the makefile.

@MartijnVisser
Copy link
Contributor Author

@flinkbot run azure

2 similar comments
@MartijnVisser
Copy link
Contributor Author

@flinkbot run azure

@MartijnVisser
Copy link
Contributor Author

@flinkbot run azure

@MartijnVisser
Copy link
Contributor Author

@dianfu I think all issues have now been resolved, PTAL

Copy link
Contributor

@HuangXingBo HuangXingBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

niklassemmler pushed a commit to niklassemmler/flink that referenced this pull request Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants