Skip to content

Conversation

RocMarshal
Copy link
Contributor

What is the purpose of the change

Translate the formats/hadoop page into Chinese.

Brief change log

Translate the formats/hadoop page into Chinese.
file: location: docs/content.zh/docs/connectors/datastream/formats/hadoop.md

Verifying this change

a pure documentation translation task.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit f7553fc (Mon Jan 24 15:16:13 UTC 2022)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 24, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@RocMarshal
Copy link
Contributor Author

Hi, @Thesharing , May I get your help to review it? Thank you.

Copy link
Contributor

@Thesharing Thesharing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing this translation to the Flink community. Your translation is great. I believe your translation will help Chinese Flink users understand the docs better. I have two minor suggestions:

  1. "输入格式" is not widely used to translate Input Format. It may confuse readers because they don't know what "输入格式" is. Maybe leaving it untranslated is better.
  2. In the original text, sometimes "InputFormat" is wrapped with ``, sometimes it is not. Maybe we should keep it consistent. All InputFormat and OutputFormat should be wrapped with ``.

These suggestions may not be applicable. Feel free to have a discussion with me. By the way, since I'm not a Flink committer, I don't have the privilege to merge this pull request.

@RocMarshal
Copy link
Contributor Author

@Thesharing Thank you very much for the comments. Updated it.

@RocMarshal
Copy link
Contributor Author

RocMarshal commented Feb 12, 2022

@gaoyunhaii @wuchong Could you help me to merge it if there's nothing Inappropriate? Thank you very much.

@RocMarshal
Copy link
Contributor Author

@flinkbot run azure

Copy link
Contributor

@gaoyunhaii gaoyunhaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @RocMarshal for the translating and @Thesharing for the review!

@gaoyunhaii gaoyunhaii closed this in 1cdb659 Mar 1, 2022
JasonLeeCoding pushed a commit to JasonLeeCoding/flink that referenced this pull request May 27, 2022
zstraw pushed a commit to zstraw/flink that referenced this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants