-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-25789][docs-zh] Translate the formats/hadoop page into Chinese. #18480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit f7553fc (Mon Jan 24 15:16:13 UTC 2022) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
Hi, @Thesharing , May I get your help to review it? Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing this translation to the Flink community. Your translation is great. I believe your translation will help Chinese Flink users understand the docs better. I have two minor suggestions:
- "输入格式" is not widely used to translate
Input Format
. It may confuse readers because they don't know what "输入格式" is. Maybe leaving it untranslated is better. - In the original text, sometimes "InputFormat" is wrapped with ``, sometimes it is not. Maybe we should keep it consistent. All
InputFormat
andOutputFormat
should be wrapped with ``.
These suggestions may not be applicable. Feel free to have a discussion with me. By the way, since I'm not a Flink committer, I don't have the privilege to merge this pull request.
Co-authored-by: Zhilong Hong <cyprestar@outlook.com>
c674544
to
20e7cf0
Compare
@Thesharing Thank you very much for the comments. Updated it. |
@gaoyunhaii @wuchong Could you help me to merge it if there's nothing Inappropriate? Thank you very much. |
@flinkbot run azure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @RocMarshal for the translating and @Thesharing for the review!
What is the purpose of the change
Translate the formats/hadoop page into Chinese.
Brief change log
Translate the formats/hadoop page into Chinese.
file: location: docs/content.zh/docs/connectors/datastream/formats/hadoop.md
Verifying this change
a pure documentation translation task.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation