Skip to content

Conversation

nyingping
Copy link
Contributor

@nyingping nyingping commented Feb 11, 2022

What is the purpose of the change

fixed some causing ambiguities including the 'shit' comment
such as:
@param shiftTimeZone the shit timezone of the window

Brief change log

(for example:)

  • The TaskInfo is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

fixed some causing ambiguities including the 'shit' comment
fixed some causing ambiguities including the 'shit' comment
@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 5fca653 (Fri Feb 11 09:25:23 UTC 2022)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 11, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@nyingping nyingping changed the title [FLINK-26086][docs]fixed some causing ambiguities including the 'shit' comment [hotfix][docs]fixed some causing ambiguities including the 'shit' comment Feb 11, 2022
@nyingping
Copy link
Contributor Author

@flinkbot run azure

Copy link
Contributor

@RyanSkraba RyanSkraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this bit of cleanup!

@nyingping
Copy link
Contributor Author

@RyanSkraba
thank you!

@nyingping nyingping changed the title [hotfix][docs]fixed some causing ambiguities including the 'shit' comment [FLINK-26086][docs]fixed some causing ambiguities including the 'shit' comment Feb 24, 2022
@nyingping
Copy link
Contributor Author

@wuchong could you have a look when you have chance? thanks in advance!

@nyingping
Copy link
Contributor Author

Hi @MartijnVisser , could you help me to review this PR.Thanks in advance!

@nyingping nyingping changed the title [FLINK-26086][docs]fixed some causing ambiguities including the 'shit' comment [hotfix] fixed some causing ambiguities including the 'shit' comment Jun 21, 2022
Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nyingping Thanks, this shouldn't be in the code base.

@MartijnVisser MartijnVisser reopened this Jun 21, 2022
@MartijnVisser MartijnVisser merged commit c08f33d into apache:master Jun 21, 2022
@MartijnVisser MartijnVisser self-assigned this Jun 21, 2022
huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Jun 27, 2022
[hotfix] Removed foul language. This closes apache#18722
zstraw pushed a commit to zstraw/flink that referenced this pull request Jul 4, 2022
[hotfix] Removed foul language. This closes apache#18722
ericccarlson pushed a commit to ericccarlson/flink that referenced this pull request Jul 11, 2022
[hotfix] Removed foul language. This closes apache#18722
liujiawinds pushed a commit to liujiawinds/flink that referenced this pull request Jul 22, 2022
[hotfix] Removed foul language. This closes apache#18722
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants