-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[hotfix] fixed some causing ambiguities including the 'shit' comment #18722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fixed some causing ambiguities including the 'shit' comment
fixed some causing ambiguities including the 'shit' comment
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 5fca653 (Fri Feb 11 09:25:23 UTC 2022) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
@flinkbot run azure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for doing this bit of cleanup!
@RyanSkraba |
@wuchong could you have a look when you have chance? thanks in advance! |
Hi @MartijnVisser , could you help me to review this PR.Thanks in advance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nyingping Thanks, this shouldn't be in the code base.
[hotfix] Removed foul language. This closes apache#18722
[hotfix] Removed foul language. This closes apache#18722
[hotfix] Removed foul language. This closes apache#18722
[hotfix] Removed foul language. This closes apache#18722
What is the purpose of the change
fixed some causing ambiguities including the 'shit' comment
such as:
@param shiftTimeZone the shit timezone of the window
Brief change log
(for example:)
Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation