[FLINK-3735] Make DataSetUnionRule match only for union-all #1874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| val union: LogicalUnion = call.rel(0).asInstanceOf[LogicalUnion] | ||
| union.all | ||
| } | ||
| def convert(rel: RelNode): RelNode = { |
There was a problem hiding this comment.
Add a newline between the methods. I also looks like the indention of {{convert}} is a bit messed up. Can you correct that as well?
|
Just a minor style comment. Good to merge otherwise. Thanks @vasia |
|
Thanks. I'll fix the style and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
UnionToDistinctRuleconverts all unions to union-all + distinct, so this is just an extra check to make sure that unions are not translated in case the rule is removed or won't match.