Skip to content

Conversation

fpompermaier
Copy link
Contributor

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

  • [X ] General
    • The pull request references the related JIRA issue
    • The pull request addresses only one issue
    • Each commit in the PR has a meaningful commit message
  • [ X] Documentation (missing web site)
    • Documentation has been added for new functionality
    • Old documentation affected by the pull request has been updated
    • JavaDoc for public methods has been added
  • [X ] Tests & Build
    • Functionality added by the pull request is covered by tests
    • mvn clean verify has been executed successfully locally or a Travis build has passed

Improved JDBCInputFormat (FLINK-3570), fixed test Exceptions in the @afterclass due to unclosed resources and removed unnecessary close()

Still to decide how to proceed with TODOs in the code

@afterclass due to unclosed resources and removed unnecessary close()
@uce
Copy link
Contributor

uce commented Apr 14, 2016

I think you used the wrong JIRA issue ID.

@fpompermaier
Copy link
Contributor Author

Yes Ufuk, you're right! it is 3750...do I have to reissue a PR with the right branch name?

@zentol
Copy link
Contributor

zentol commented Apr 14, 2016

you should a) rename the PR and b) force-push your branch with the correct jira ID.

or just re-open, as you wish.

@fpompermaier fpompermaier changed the title Improved JDBCInputFormat (FLINK-3570), fixed test Exceptions in the Improved JDBCInputFormat (FLINK-3750), fixed test Exceptions in the Apr 14, 2016
@fpompermaier fpompermaier deleted the FLINK-3570 branch April 14, 2016 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants