-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-26295][table] Operation strategies should allow having spaces … #18874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…between operation and semicolon
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 7a77458 (Tue Feb 22 11:53:16 UTC 2022) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
@flinkbot run azure |
...-planner/src/main/java/org/apache/flink/table/planner/parse/ClearOperationParseStrategy.java
Outdated
Show resolved
Hide resolved
...ner/src/test/java/org/apache/flink/table/planner/operations/SqlToOperationConverterTest.java
Outdated
Show resolved
Hide resolved
...ner/src/test/java/org/apache/flink/table/planner/operations/SqlToOperationConverterTest.java
Outdated
Show resolved
Hide resolved
@flinkbot run azure |
@slinkydeveloper thank you for your feedback, I addressed all the comments. |
@godfreyhe sorry for the poke... |
…ween operation and semicolon This closes apache#18874.
…ween operation and semicolon This closes apache#18874.
…ween operation and semicolon This closes apache#18874.
What is the purpose of the change
The PR allows to have spaces between sql client command and semicolon like it was before #18363
e.g.
Now it fails as described in FLINK-26295
Brief change log
Added spaces support in Operations
Verifying this change
There is a new test org.apache.flink.table.planner.operations.SqlToOperationConverterTest#testSqlClientCommands
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: ( no)Documentation