Skip to content

Conversation

snuyanzin
Copy link
Contributor

What is the purpose of the change

The PR allows to have spaces between sql client command and semicolon like it was before #18363

e.g.

HELP ;
QUIT ;

Now it fails as described in FLINK-26295

Brief change log

Added spaces support in Operations

Verifying this change

There is a new test org.apache.flink.table.planner.operations.SqlToOperationConverterTest#testSqlClientCommands

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: ( no )
  • The runtime per-record code paths (performance sensitive): ( no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no )
  • The S3 file system connector: ( no )

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 7a77458 (Tue Feb 22 11:53:16 UTC 2022)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 22, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@snuyanzin
Copy link
Contributor Author

@flinkbot run azure

@snuyanzin
Copy link
Contributor Author

@flinkbot run azure

@snuyanzin
Copy link
Contributor Author

@slinkydeveloper thank you for your feedback, I addressed all the comments.
Please have a look once you have time.
Please let me know if I need to squash commits

@snuyanzin
Copy link
Contributor Author

@godfreyhe sorry for the poke...
could you please have a look since it is already approved and it is related to #18363

@twalthr twalthr closed this in c83ec41 Mar 14, 2022
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink that referenced this pull request Mar 15, 2022
@snuyanzin snuyanzin deleted the flink26295 branch May 5, 2022 11:14
JasonLeeCoding pushed a commit to JasonLeeCoding/flink that referenced this pull request May 27, 2022
zstraw pushed a commit to zstraw/flink that referenced this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants