-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-27304][hive] Calcite's varbinary type should be converted to Hive's binary type. #19562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@beyond1920 Could you please help review? |
return hiveShim.getIntervalDayTimeTypeInfo(); | ||
case BINARY: | ||
case VARBINARY: | ||
return TypeInfoFactory.binaryTypeInfo; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find that there exist other types which are not present in flink code, for example, REAL, TIME_WITH_LOCAL_TIME_ZONE. Should we also add them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your reminer.
Yes, we also should all them. And we have also a jira for TIME_WITH_LOCAL_TIME_ZONE FLINK-23224.
I will support it in other pr.
…ive's binary type.
…ive's binary type. This closes apache#19562
…ive's binary type. This closes apache#19562
…ive's binary type. This closes apache#19562
…ive's binary type. This closes apache#19562
…ive's binary type. This closes apache#19562
What is the purpose of the change
To make Calcite's varbinary type convert to Hive's binary type instead of defualt void type which is not supported in Flink.
Brief change log
HiveParserTypeConverter#convertPrimitiveType
and convert it to Hive's binary typeVerifying this change
Additional query in HiveDialectQueryITCase#testAdditionalQueries.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation