-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-28107][python][connector/elasticsearch] Support id of document is null #20002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianfu
reviewed
Jun 18, 2022
.../src/main/java/org/apache/flink/connector/elasticsearch/sink/SimpleElasticsearchEmitter.java
Outdated
Show resolved
Hide resolved
@deadwind4 Thanks for the update! LGTM overall. I'm wondering if we should rename SimpleElasticsearchEmitter to MapElasticsearchEmitter to indicate that it actually accepts Map as input. What's your thought? |
@dianfu make sense to me. |
dianfu
approved these changes
Jun 20, 2022
huangxiaofeng10047
pushed a commit
to huangxiaofeng10047/flink
that referenced
this pull request
Jun 27, 2022
… is null This closes apache#20002.
zstraw
pushed a commit
to zstraw/flink
that referenced
this pull request
Jul 4, 2022
… is null This closes apache#20002.
liujiawinds
pushed a commit
to liujiawinds/flink
that referenced
this pull request
Jul 22, 2022
… is null This closes apache#20002.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Support id of document is null
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes)Documentation