Skip to content

Conversation

a49a
Copy link
Contributor

@a49a a49a commented Jun 17, 2022

What is the purpose of the change

Support id of document is null

Brief change log

  • Add IndexRequest in SimpleElasticsearchEmitter

Verifying this change

This change added tests and can be verified as follows:

  • Added integration tests for end-to-end deployment with large payloads (100MB)

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@a49a a49a marked this pull request as draft June 17, 2022 08:55
@flinkbot
Copy link
Collaborator

flinkbot commented Jun 17, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@dianfu
Copy link
Contributor

dianfu commented Jun 19, 2022

@deadwind4 Thanks for the update! LGTM overall. I'm wondering if we should rename SimpleElasticsearchEmitter to MapElasticsearchEmitter to indicate that it actually accepts Map as input. What's your thought?

@a49a
Copy link
Contributor Author

a49a commented Jun 20, 2022

@dianfu make sense to me.

@dianfu dianfu closed this in 11910d5 Jun 20, 2022
huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Jun 27, 2022
zstraw pushed a commit to zstraw/flink that referenced this pull request Jul 4, 2022
liujiawinds pushed a commit to liujiawinds/flink that referenced this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants