[FLINK-3939] [tableAPI] Prevent translation of unsupported distinct aggregates and grouping sets. #2014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ggregates and grouping sets.
| agg.getInput.getRowType, | ||
| agg.getGroupSet.toArray) | ||
| } | ||
| override def matches(call: RelOptRuleCall): Boolean = { |
There was a problem hiding this comment.
Is that possible we add an UnsupportedOperatorRule to match unsupported plan and throws an TableException in convert method?
There was a problem hiding this comment.
That's a good idea. I won't work for all unsupported operators (inner equi-joins are initially Cartesian products + filters before translation rules merge join and filter), but some operations such as distinct aggregates are not rewritten be rules such that we can throw an exception when they are observed.
|
Thanks for the review @yjshen! |
mbode
pushed a commit
to mbode/flink
that referenced
this pull request
May 27, 2016
…ggregates and grouping sets. This closes apache#2014
hequn8128
pushed a commit
to hequn8128/flink
that referenced
this pull request
Jun 22, 2017
…ggregates and grouping sets. This closes apache#2014
Naruto0-sudoy
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes
DataSetAggregateRuleto not translateLogicalAggregateoperators that include distinct aggregates or grouping sets. Such aggregations are currently not supported byDataSetAggregate.mvn clean verifyhas been executed successfully locally or a Travis build has passed