Skip to content

Conversation

swuferhong
Copy link
Contributor

@swuferhong swuferhong commented Jul 12, 2022

What is the purpose of the change

At first, this PR only wanted to support syntax DESCRIBE EXTENDED to print table statistics. But now, this PR is aims to realize syntax DESCRIBE/DESC [EXTENDED] [catalog_name.][database_name.]table_name [PARTITION(partition_spec)] [col_name]. Syntax implementation, get statistics from catalog and printing are mainly completed in this PR

Brief change log

  • Re implemented method SqlRichDescribeTable in parserImpls.ftl
  • In TableEnvironmentImpl, realize buildDescribeResult to build desc result.
  • realize listPartitionsByFilter method in GenericInMemoryCatalog to support get partial partitions for genericInMemoryCatalog.
  • Adding UT test in 'TableEnvironmentTest' to cover desc [extended] for none-partitioned table and partitioned table.

Verifying this change

  • Adding UT test in 'TableEnvironmentTest' to cover desc [extended] for none-partitioned table and partitioned table.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): don't know
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
    now there is no docs about this feature. will be adding

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 12, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@godfreyhe godfreyhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, I left some comments

@swuferhong swuferhong changed the title [FLINK-28074][table-planner] show statistics details for DESCRIBE EXT… [FLINK-28074][table-planner] show statistics details for DESCRIBE EXTENDED Jul 13, 2022
@swuferhong swuferhong force-pushed the FLINK-28074 branch 2 times, most recently from 3a19e86 to 5b47c7f Compare September 21, 2022 03:46
@lsyldliu
Copy link
Contributor

Thanks for your contribution, I will take a look as soon as possible.

@Aitozi
Copy link
Contributor

Aitozi commented Apr 11, 2023

I think it's a very useful auxiliary command, can we move this PR forward @swuferhong @godfreyhe ?

Copy link

This PR is being marked as stale since it has not had any activity in the last 180 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out to the [community](https://flink.apache.org/what-is-flink/community/).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 90 days, it will be automatically closed.

@github-actions github-actions bot added the stale label Jan 15, 2025
Copy link

This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants