Skip to content

Conversation

DavidLiu001
Copy link
Contributor

…nkWriter

What is the purpose of the change

Change the abstract method's parameter naming in AsyncSinkWriter and AsyncSinkWriterTest

From Consumer<List> requestResult
to Consumer<List> requestToRetry

This is because the consumer here is supposed to accept a list of requests that need to be retried.

Brief change log

flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriterTest.java
Just rename the parameter of requestResult to requestToRetry

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no) no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no) no
  • The serializers: (yes / no / don't know) no
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) no
  • The S3 file system connector: (yes / no / don't know) no

Documentation

  • Does this pull request introduce a new feature? (yes / no) no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 22, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@DavidLiu001 DavidLiu001 requested a review from dannycranmer July 25, 2022 01:44
@dannycranmer
Copy link
Contributor

@DavidLiu001 you have a build failure on the CI. Can you please address this and then I will merge. Thanks

@DavidLiu001
Copy link
Contributor Author

Close this pull request and I Will open a new Pull Request

@dannycranmer
Copy link
Contributor

dannycranmer commented Jul 26, 2022

@DavidLiu001 in future instead of opening a new PR, you can simply push a new commit to you branch and the PR will automatically update? You can even squash and force push to rewrite the branch completely. We lose/spread the comment history when opening multiple PRs.
Thanks.

@DavidLiu001
Copy link
Contributor Author

Nice, I will follow your suggestion for the later PR

1 similar comment
@DavidLiu001
Copy link
Contributor Author

Nice, I will follow your suggestion for the later PR

@dannycranmer
Copy link
Contributor

Superseded by #20360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants