[FLINK-4074] Make metric reporters less blocking #2105
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zentol
commented
Jun 15, 2016
zentol
commented
- adds a cancel flag to the StatsDReporter, which is checked before sending every metric. set to true when stop() is called.
- switched from Timer to ScheduledExecutorService, in the hopes of better forced termination.
- also contains a hotfix preventing exceptions occurring in (un)register to be propagated
| reporter.notifyOfAddedMetric(metric, metricName, group); | ||
| } | ||
| } catch (Exception e) { | ||
| LOG.error("Error while registering metric.", e); |
There was a problem hiding this comment.
Why do we add the try-catch here? notifyOfAddedMetric does not declare thrown exceptions. Thus we try to catch unchecked exceptions here? Which unchecked exceptions did you encounter here?
There was a problem hiding this comment.
this is simply a fail-safe to ensure that no exceptions are thrown. Generally a reporter shouldn't throw an Exception in these methods, but I'd rather be safe then sorry.
|
Good improvements to make the Reporters less blocking @zentol. I had only some minor comments. After addressing them, I think the PR is good to be merged :-) |
-executor only started when needed -executor properly shutdown -renamed cancel flag to closed
|
@tillrohrmann Addressed all your comments. |
|
Very good work @zentol. +1 for merging. |
|
merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.