[FLINK-29750][connector-jdbc] Improve PostgresCatalog#listTables() by reusing resources #21146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Currently the
PostgresCatalog#listTables()
creates a new connection and prepared statement for every schema and table when listing tables. This can be optimized by reusing those resources.Brief change log
(for example:)
extractColumnValuesByStatement
in base classAbstractJdbcCatalog
PostgresCatalog#listTables()
Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
(Please pick either of the following options)
This change is already covered by existing tests, such as PostgresCatalogTest.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation