[FLINK-30495][table-api] Introduce TableChange to represent ADD change #21566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsk119
force-pushed
the
add
branch
2 times, most recently
from
e3e2ee9 to
3d2ecc8
Compare
LadyForest
reviewed
Dec 29, 2022
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/TableChange.java
Outdated
Show resolved
Hide resolved
...able-planner/src/main/java/org/apache/flink/table/planner/utils/OperationConverterUtils.java
Show resolved
Hide resolved
| newProperties, | ||
| catalogTable.getComment())); | ||
| catalogTable.getComment()); | ||
| if (addReplaceColumns.isReplace()) { |
There was a problem hiding this comment.
Could you explain more about why differentiate add/replace operations?
There was a problem hiding this comment.
Because ALTER TABLE REPLACE syntax may also remove all columns before.
For example, "ALTER TABLE test_change REPLACE COLUMNS (a int, b int);" will remove column 'c' from test_change's schema.[1]
So I think we can support this after introducing DROP change.
...le-planner/src/main/java/org/apache/flink/table/planner/operations/AlterSchemaConverter.java
Outdated
Show resolved
Hide resolved
...le-planner/src/main/java/org/apache/flink/table/planner/operations/AlterSchemaConverter.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jane Chan <55568005+LadyForest@users.noreply.github.com>
|
@flinkbot run azure |
LadyForest
approved these changes
Dec 30, 2022
chucheng92
pushed a commit
to chucheng92/flink
that referenced
this pull request
Feb 3, 2023
akkinenivijay
pushed a commit
to krisnaru/flink
that referenced
this pull request
Feb 11, 2023
Tan-JiaLiang
pushed a commit
to Tan-JiaLiang/flink
that referenced
this pull request
Mar 4, 2024
This closes apache#21566 (cherry picked from commit 5c3658a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Introduce TableChange to represend ALTER TABLE ADD syntax.
Brief change log
AlterSchemaConverterbuild the TableChangeVerifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
This change is already covered by existing tests, such as SqlToOperationConverterTest.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation