Skip to content

[FLINK-31227][docs] Remove scala version for file system artifactId #22039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2023
Merged

[FLINK-31227][docs] Remove scala version for file system artifactId #22039

merged 2 commits into from
Mar 13, 2023

Conversation

kination
Copy link
Contributor

@kination kination commented Feb 27, 2023 •
edited
Loading

What is the purpose of the change

Current artifacts for flink-orc, flink-parquet don't have scala version, but document guide includes it.
https://mvnrepository.com/artifact/org.apache.flink/flink-orc/1.16.0
https://mvnrepository.com/artifact/org.apache.flink/flink-parquet/1.16.0

Brief change log

Remove scala version for file system artifactId

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 27, 2023 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

MartijnVisser
MartijnVisser requested changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kination Thanks for the PR, please also change this for the Chinese documentation

@kination
Copy link
Contributor Author

@MartijnVisser thanks for feedback. Applied 👍

MartijnVisser
MartijnVisser approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MartijnVisser MartijnVisser merged commit a8848f8 into apache:master Mar 13, 2023
MartijnVisser pushed a commit that referenced this pull request Mar 13, 2023
@kination @MartijnVisser
[FLINK-31227][docs] Remove Scala suffix for ORC and Parquet format do…
a8d7ec9 
…wnload links on the the FileSystem documentation. This closes #22039

Remove Scala suffix for ORC and Parquet format download links on the the FileSystem documentation

(cherry picked from commit a8848f8)
MartijnVisser pushed a commit that referenced this pull request Mar 13, 2023
@kination @MartijnVisser
[FLINK-31227][docs] Remove Scala suffix for ORC and Parquet format do…
f200775 
…wnload links on the the FileSystem documentation. This closes #22039

Remove Scala suffix for ORC and Parquet format download links on the the FileSystem documentation

(cherry picked from commit a8848f8)
MartijnVisser pushed a commit that referenced this pull request Mar 13, 2023
@kination @MartijnVisser
[FLINK-31227][docs] Remove Scala suffix for ORC and Parquet format do…
cb5dbf5 
…wnload links on the the FileSystem documentation. This closes #22039

Remove Scala suffix for ORC and Parquet format download links on the the FileSystem documentation

(cherry picked from commit a8848f8)
@kination kination deleted the doc/file-conn-remove-scalaver branch March 13, 2023 10:09
MartijnVisser added a commit that referenced this pull request Mar 14, 2023
@MartijnVisser
Revert "[FLINK-31227][docs] Remove Scala suffix for ORC and Parquet f…
78bae43 
…ormat download links on the the FileSystem documentation. This closes #22039"

This reverts commit cb5dbf5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartijnVisser MartijnVisser MartijnVisser approved these changes

Assignees
No one assigned
Labels
component=<none>
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kination @flinkbot @MartijnVisser