Skip to content

[FLINK-31324][connector] Make previous SingleThreadFetcherManager constructor deprecated #22094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[FLINK-31324][connector] Make previous SingleThreadFetcherManager constructor deprecated #22094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions ...ava/org/apache/flink/connector/base/source/reader/fetcher/SingleThreadFetcherManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,25 @@ public class SingleThreadFetcherManager<E, SplitT extends SourceSplit>
* the same queue instance that is also passed to the {@link SourceReaderBase}.
* @param splitReaderSupplier The factory for the split reader that connects to the source
* system.
* @deprecated Please use {@link #SingleThreadFetcherManager(FutureCompletingBlockingQueue,
* Supplier, Configuration)} instead.
*/
@Deprecated
public SingleThreadFetcherManager(
FutureCompletingBlockingQueue<RecordsWithSplitIds<E>> elementsQueue,
Supplier<SplitReader<E, SplitT>> splitReaderSupplier) {
this(elementsQueue, splitReaderSupplier, new Configuration());
}

/**
* Creates a new SplitFetcherManager with a single I/O threads.
*
* @param elementsQueue The queue that is used to hand over data from the I/O thread (the
* fetchers) to the reader (which emits the records and book-keeps the state. This must be
* the same queue instance that is also passed to the {@link SourceReaderBase}.
* @param splitReaderSupplier The factory for the split reader that connects to the source
* system.
* @param configuration The configuration to create the fetcher manager.
*/
public SingleThreadFetcherManager(
FutureCompletingBlockingQueue<RecordsWithSplitIds<E>> elementsQueue,
Expand All @@ -69,6 +88,7 @@ public SingleThreadFetcherManager(
* the same queue instance that is also passed to the {@link SourceReaderBase}.
* @param splitReaderSupplier The factory for the split reader that connects to the source
* system.
* @param configuration The configuration to create the fetcher manager.
* @param splitFinishedHook Hook for handling finished splits in split fetchers
*/
@VisibleForTesting
Expand Down
2 changes: 2 additions & 0 deletions .../main/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ public abstract class SplitFetcherManager<E, SplitT extends SourceSplit> {
*
* @param elementsQueue the queue that split readers will put elements into.
* @param splitReaderFactory a supplier that could be used to create split readers.
* @param configuration the configuration of this fetcher manager.
*/
public SplitFetcherManager(
FutureCompletingBlockingQueue<RecordsWithSplitIds<E>> elementsQueue,
Expand All @@ -111,6 +112,7 @@ public SplitFetcherManager(
*
* @param elementsQueue the queue that split readers will put elements into.
* @param splitReaderFactory a supplier that could be used to create split readers.
* @param configuration the configuration of this fetcher manager.
* @param splitFinishedHook Hook for handling finished splits in split fetchers.
*/
@VisibleForTesting
Expand Down