Skip to content

Conversation

Vancior
Copy link
Contributor

@Vancior Vancior commented Mar 6, 2023

What is the purpose of the change

This PR fixes elements are not sorted under the same key in Python keyed broadcast operator under batch mode.

Verifying this change

This change is already covered by existing tests, test_keyed_co_broadcast_* in test_data_stream.py, which accidently works under general configuration parallelism=2 before this fix.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 6, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@Vancior Vancior changed the title [FLINK-31337][Python] Fix python keyed broadcast batch operator input not sorted [FLINK-31337][python] Fix python keyed broadcast batch operator input not sorted Mar 6, 2023
@dianfu dianfu closed this in 4fd3cf1 Mar 6, 2023
dianfu pushed a commit that referenced this pull request Mar 6, 2023
dianfu pushed a commit that referenced this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants