Skip to content

Conversation

shuiqiangchen
Copy link
Contributor

What is the purpose of the change

Fix the bug that it excludes all metadata and computed columns when doing preValidateRewrite with partial insert.

Brief change log

  • Added util to get persisted schema.
  • Apply persisted columns as target row type when doing pre-validate rewrite for partial insert.

Verifying this change

This change has test cases covered in PartialInsertTest.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

…ns in column list of a partial-insert statement

This closes apache#21897

(cherry picked from commit a2d78e6)
@shuiqiangchen
Copy link
Contributor Author

@lincoln-lil Here is the backport pr for release-1.17, please have a look.

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 6, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@lincoln-lil lincoln-lil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lincoln-lil lincoln-lil merged commit 865a056 into apache:release-1.17 Mar 7, 2023
Tan-JiaLiang pushed a commit to Tan-JiaLiang/flink that referenced this pull request Mar 4, 2024
…ns in column list of a partial-insert statement

This closes apache#22109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants