Skip to content

Conversation

wuchong
Copy link
Member

@wuchong wuchong commented Jul 20, 2016

[FLINK-4180] [FLINK-4181] [table] add Batch SQL and Stream SQL and Stream Table API examples

I add 4 examples for flink-table module

  1. org.apache.flink.examples.java.JavaSQLExample: Batch SQL in Java
  2. org.apache.flink.examples.scala.WordCountSQL: Batch SQL in Scala
  3. org.apache.flink.examples.scala.StreamSQLExample: Stream SQL in Scala
  4. org.apache.flink.examples.scala.StreamTableExample: Stream Table API in Scala


public static class WC {
public String word;
public long frequence;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

knitpick: change that to 'frequency' :)

@wuchong
Copy link
Member Author

wuchong commented Jul 24, 2016

@smarthi Thanks for reviewing. I have addressed the typo.

}

public static void main(String[] args) throws Exception {
ExecutionEnvironment env = ExecutionEnvironment.getExecutionEnvironment();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would suggest to the same comment as in WordCountSQL.scala:
// set up execution environment

@nssalian
Copy link

LGTM after the nits. But I would request someone else have a pass over it before moving forward since I am new to the code.

@twalthr
Copy link
Contributor

twalthr commented Aug 2, 2016

Thanks @wuchong. I will add some additional comments/formatting and merge it...

twalthr pushed a commit to twalthr/flink that referenced this pull request Aug 2, 2016
@asfgit asfgit closed this in 123c637 Aug 2, 2016
delding pushed a commit to delding/flink that referenced this pull request Aug 2, 2016
@wuchong wuchong deleted the table-example branch May 15, 2017 02:14
hequn8128 pushed a commit to hequn8128/flink that referenced this pull request Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants