Skip to content

[FLINK-28513][Backport][release-1.18] Fix Flink Table API CSV streaming sink throws #23352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2023
Merged

[FLINK-28513][Backport][release-1.18] Fix Flink Table API CSV streaming sink throws #23352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ...e/src/main/java/org/apache/flink/fs/s3/common/writer/S3RecoverableFsDataOutputStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,16 @@ public long getPos() throws IOException {

@Override
public void sync() throws IOException {
fileStream.sync();
lock();
try {
fileStream.flush();
openNewPartIfNecessary(userDefinedMinPartSize);
Committer committer = upload.snapshotAndGetCommitter();
committer.commitAfterRecovery();
closeForCommit();
} finally {
unlock();
}
}

@Override
Expand Down
10 changes: 10 additions & 0 deletions ...c/test/java/org/apache/flink/fs/s3/common/writer/S3RecoverableFsDataOutputStreamTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,16 @@ public void closeForCommitOnClosedStreamShouldFail() throws IOException {
streamUnderTest.closeForCommit().commit();
}

@Test(expected = Exception.class)
public void testSync() throws IOException {
streamUnderTest.write(bytesOf("hello"));
streamUnderTest.write(bytesOf(" world"));
streamUnderTest.sync();
assertThat(multipartUploadUnderTest, hasContent(bytesOf("hello world")));
streamUnderTest.write(randomBuffer(RefCountedBufferingFileStream.BUFFER_SIZE + 1));
assertThat(multipartUploadUnderTest, hasContent(bytesOf("hello world")));
}

// ------------------------------------------------------------------------------------------------------------
// Utils
// ------------------------------------------------------------------------------------------------------------
Expand Down