Skip to content

Conversation

WencongLiu
Copy link
Contributor

What is the purpose of the change

Add an article to guide users to migrate their DataSet jobs to DataStream.

Brief change log

  • Add an article to guide users to migrate their DataSet jobs to DataStream.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 6, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@WencongLiu
Copy link
Contributor Author

@flinkbot run azure

Copy link
Contributor

@yunfengzhou-hub yunfengzhou-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Left some comments as below.

@WencongLiu
Copy link
Contributor Author

Thanks for the careful review of @yunfengzhou-hub . I've updated a round of changes. Please take a look when you have time. 😊

Copy link
Contributor

@yunfengzhou-hub yunfengzhou-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Left some comments as below.

Copy link
Contributor

@yunfengzhou-hub yunfengzhou-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Looks much better now. Left some comments as below.

@xintongsong Could you please take a look at this PR?

@yunfengzhou-hub
Copy link
Contributor

Thanks for the update! LGTM overall except the idea to divide transformations into 4 categories.

@WencongLiu WencongLiu force-pushed the dev_FLINK-33041 branch 3 times, most recently from d61a401 to 321203c Compare October 24, 2023 07:21
Copy link
Contributor

@xintongsong xintongsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WencongLiu, thanks for addressing my comments. LGTM.

According to the contribution guidelines, please add an identical markdown file in content.zh/ and open a Jira ticket for the translation task.

@WencongLiu
Copy link
Contributor Author

@WencongLiu, thanks for addressing my comments. LGTM.

According to the contribution guidelines, please add an identical markdown file in content.zh/ and open a Jira ticket for the translation task.

Thanks for the review! I have added an identical markdown file in content.zh/. I'll open a Jira ticket for the translation task after this pull request is merged.

xintongsong pushed a commit that referenced this pull request Nov 2, 2023
…to migrate their DataSet jobs to DataStream

This closes #23362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants