Skip to content

Conversation

elkhand
Copy link
Contributor

@elkhand elkhand commented Sep 8, 2023

FLINK-32885 Refactoring: Moving UrlPrefixDecorator into flink-clients so it can be used by RestClusterClient for PyFlink remote execution

What is the purpose of the change

UrlPrefixDecorator is introduced in flink-sql-gateway module, which has a dependency on flink-clients module. RestClusterClient will also need to use UrlPrefixDecorator for supporting PyFlink remote execution. Will refactor related classes to achieve this.

This PR will be used in FLINK-32884 PyFlink remote execution should support URLs with paths and https scheme

Brief change log

  • Moved UrlPrefixDecorator class from flink-sql-gateway module into flink-clients module

Verifying this change

This change is already covered by existing tests, such as :

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): yes
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 8, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@tweise
Copy link
Contributor

tweise commented Sep 11, 2023

@afedulov PTAL

Copy link
Contributor

@afedulov afedulov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

…nts so it can be used by RestClusterClient for PyFlink remote execution
@elkhand elkhand force-pushed the 32885-uriPrefiDecorator branch from 9b4f77c to 161ef18 Compare September 12, 2023 17:55
@tweise tweise merged commit e7eeea0 into apache:master Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants