-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-33022] Log an error when enrichers defined as part of the configuration can not be found/loaded #23386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pgaref Thanks for the quick fix, I've left some comments here
flink-runtime/src/main/java/org/apache/flink/runtime/failure/FailureEnricherUtils.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/test/java/org/apache/flink/runtime/failure/FailureEnricherUtilsTest.java
Show resolved
Hide resolved
@huwh do you mind taking a quick look here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pgaref for preparing this PR. I left two comments. Please take a look.
flink-runtime/src/test/java/org/apache/flink/runtime/failure/FailureEnricherUtilsTest.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/failure/FailureEnricherUtils.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't express myself clearly earlier. Please take a look again
flink-runtime/src/main/java/org/apache/flink/runtime/failure/FailureEnricherUtils.java
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/failure/FailureEnricherUtils.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/failure/FailureEnricherUtils.java
Outdated
Show resolved
Hide resolved
… the configuration can not be found/loaded
Got it! Thanks again @huwh -- updated! |
What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
Currently
jobmanager.failure-enrichers
is currently used as a filter to only allow loading enrichers that are defined, and not the other way around. However, we should also notify the users if there are enrichers defined that can not be found/loaded.https://issues.apache.org/jira/browse/FLINK-33022
Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation