Skip to content

Conversation

pgaref
Copy link
Contributor

@pgaref pgaref commented Sep 9, 2023

What is the purpose of the change

(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)

Brief change log

Currently jobmanager.failure-enrichers is currently used as a filter to only allow loading enrichers that are defined, and not the other way around. However, we should also notify the users if there are enrichers defined that can not be found/loaded.

https://issues.apache.org/jira/browse/FLINK-33022

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@pgaref
Copy link
Contributor Author

pgaref commented Sep 9, 2023

@wangzzu @zentol can you please take a look when you have a sec?

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 9, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@wangzzu wangzzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pgaref Thanks for the quick fix, I've left some comments here

@pgaref
Copy link
Contributor Author

pgaref commented Sep 11, 2023

@pgaref Thanks for the quick fix, I've left some comments here

Updated! Thanks for the review @wangzzu !

@pgaref
Copy link
Contributor Author

pgaref commented Sep 12, 2023

@huwh do you mind taking a quick look here?

Copy link
Contributor

@huwh huwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pgaref for preparing this PR. I left two comments. Please take a look.

@pgaref
Copy link
Contributor Author

pgaref commented Sep 14, 2023

Thanks @pgaref for preparing this PR. I left two comments. Please take a look.

Appreciate the review @huwh ! Updated the PR, please let me know what you think

Copy link
Contributor

@huwh huwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't express myself clearly earlier. Please take a look again

@pgaref
Copy link
Contributor Author

pgaref commented Sep 14, 2023

Sorry, I didn't express myself clearly earlier. Please take a look again

Got it! Thanks again @huwh -- updated!

@huwh huwh merged commit b51ee30 into apache:master Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants