Skip to content

[FLINK-4236] fix error handling for jar files with no main method #2347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[FLINK-4236] fix error handling for jar files with no main method #2347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions ...untime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarListHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,20 +94,23 @@ public boolean accept(File dir, String name) {
} catch (IOException ignored) {
// we simply show no entries here
}

// show every entry class that can be loaded later on.
PackagedProgram program;
for (String clazz : classes) {
clazz = clazz.trim();

PackagedProgram program = null;
try {
program = new PackagedProgram(f, clazz, new String[0]);
} catch (Exception ignored) {
// ignore jar files which throw an error upon creating a PackagedProgram
}
if (program != null) {
gen.writeStartObject();
gen.writeStringField("name", clazz);
String desc = program.getDescription();
gen.writeStringField("description", desc == null ? "No description provided" : desc);
gen.writeEndObject();
} catch (ProgramInvocationException e) {
//
}
}
gen.writeEndArray();
Expand Down