[FLINK-33179] Throw exception when serialising or deserialising ExecNode with invalid type #23488
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.table.planner.plan.nodes.exec; | ||
|
|
||
| import org.apache.flink.table.api.EnvironmentSettings; | ||
| import org.apache.flink.table.api.PlanReference; | ||
| import org.apache.flink.table.api.TableEnvironment; | ||
| import org.apache.flink.table.planner.utils.TableTestBase; | ||
|
|
||
| import org.junit.Test; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThatThrownBy; | ||
|
|
||
| /** Tests for deserialising invalid {@link org.apache.flink.table.api.CompiledPlan}. */ | ||
| public class UnsupportedNodesInPlanTest extends TableTestBase { | ||
|
|
||
| @Test | ||
| public void testInvalidType() { | ||
| final TableEnvironment tEnv = | ||
| TableEnvironment.create(EnvironmentSettings.inStreamingMode()); | ||
| assertThatThrownBy( | ||
| () -> | ||
| tEnv.loadPlan( | ||
| PlanReference.fromResource( | ||
| "/jsonplan/testInvalidTypeJsonPlan.json"))) | ||
| .hasRootCauseMessage("Unsupported exec node type: 'null_null'."); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.table.planner.plan.nodes.exec.serde; | ||
|
|
||
| import org.apache.flink.FlinkVersion; | ||
| import org.apache.flink.api.dag.Transformation; | ||
| import org.apache.flink.configuration.Configuration; | ||
| import org.apache.flink.table.api.DataTypes; | ||
| import org.apache.flink.table.data.RowData; | ||
| import org.apache.flink.table.planner.delegation.PlannerBase; | ||
| import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeBase; | ||
| import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeConfig; | ||
| import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeContext; | ||
| import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeGraph; | ||
|
|
||
| import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.ObjectWriter; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import java.util.Collections; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThatThrownBy; | ||
|
|
||
| /** Tests for {@link ExecNodeGraphJsonSerializer}. */ | ||
| class ExecNodeGraphJsonSerializerTest { | ||
|
|
||
| @Test | ||
| void testSerializingUnsupportedNode() { | ||
| final ObjectWriter objectWriter = | ||
| JsonSerdeUtil.createObjectWriter(JsonSerdeTestUtil.configuredSerdeContext()); | ||
| assertThatThrownBy( | ||
| () -> | ||
| objectWriter.writeValueAsString( | ||
| new ExecNodeGraph( | ||
| FlinkVersion.v1_18, | ||
| Collections.singletonList(new NoAnnotationNode())))) | ||
| .hasMessageContaining( | ||
| "Can not serialize ExecNode with id: 10. Missing type, this is a bug, please file a ticket"); | ||
|
There was a problem hiding this comment. I suggest rephrasing to raising a Jira and including the url. |
||
| } | ||
|
|
||
| private static class NoAnnotationNode extends ExecNodeBase<RowData> { | ||
|
|
||
| NoAnnotationNode() { | ||
| super( | ||
| 10, | ||
| ExecNodeContext.newContext(NoAnnotationNode.class), | ||
| new Configuration(), | ||
| Collections.emptyList(), | ||
| DataTypes.ROW(DataTypes.FIELD("a", DataTypes.INT())).getLogicalType(), | ||
| ""); | ||
| setInputEdges(Collections.emptyList()); | ||
| } | ||
|
|
||
| @Override | ||
| protected Transformation<RowData> translateToPlanInternal( | ||
| PlannerBase planner, ExecNodeConfig config) { | ||
| return null; | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,216 @@ | ||
| { | ||
| "flinkVersion": "1.18", | ||
| "nodes": [ | ||
| { | ||
| "id": 1, | ||
| "type": "stream-exec-table-source-scan_1", | ||
| "scanTableSource": { | ||
| "table": { | ||
| "identifier": "`default_catalog`.`default_database`.`MyTable`", | ||
| "resolvedTable": { | ||
| "schema": { | ||
| "columns": [ | ||
| { | ||
| "name": "a", | ||
| "dataType": "BIGINT" | ||
| }, | ||
| { | ||
| "name": "b", | ||
| "dataType": "INT NOT NULL" | ||
| }, | ||
| { | ||
| "name": "c", | ||
| "dataType": "VARCHAR(2147483647)" | ||
| }, | ||
| { | ||
| "name": "d", | ||
| "dataType": "TIMESTAMP(3)" | ||
| } | ||
| ], | ||
| "watermarkSpecs": [] | ||
| }, | ||
| "partitionKeys": [], | ||
| "options": { | ||
| "connector": "values", | ||
| "bounded": "false" | ||
| } | ||
| } | ||
| }, | ||
| "abilities": [ | ||
| { | ||
| "type": "ProjectPushDown", | ||
| "projectedFields": [ | ||
| [ | ||
| 0 | ||
| ], | ||
| [ | ||
| 1 | ||
| ] | ||
| ], | ||
| "producedType": "ROW<`a` BIGINT, `b` INT NOT NULL> NOT NULL" | ||
| }, | ||
| { | ||
| "type": "ReadingMetadata", | ||
| "metadataKeys": [], | ||
| "producedType": "ROW<`a` BIGINT, `b` INT NOT NULL> NOT NULL" | ||
| } | ||
| ] | ||
| }, | ||
| "outputType": "ROW<`a` BIGINT, `b` INT NOT NULL>", | ||
| "description": "TableSourceScan(table=[[default_catalog, default_database, MyTable, project=[a, b], metadata=[]]], fields=[a, b])", | ||
| "inputProperties": [] | ||
| }, | ||
| { | ||
| "id": 2, | ||
| "type": "stream-exec-exchange_1", | ||
| "inputProperties": [ | ||
| { | ||
| "requiredDistribution": { | ||
| "type": "SINGLETON" | ||
| }, | ||
| "damBehavior": "PIPELINED", | ||
| "priority": 0 | ||
| } | ||
| ], | ||
| "outputType": "ROW<`a` BIGINT, `b` INT NOT NULL>", | ||
| "description": "Exchange(distribution=[single])" | ||
| }, | ||
| { | ||
| "id": 3, | ||
| "type": "null_null", | ||
| "orderBy": { | ||
| "fields": [ | ||
| { | ||
| "index": 1, | ||
| "isAscending": true, | ||
| "nullIsLast": false | ||
| } | ||
| ] | ||
| }, | ||
| "inputProperties": [ | ||
| { | ||
| "requiredDistribution": { | ||
| "type": "UNKNOWN" | ||
| }, | ||
| "damBehavior": "PIPELINED", | ||
| "priority": 0 | ||
| } | ||
| ], | ||
| "outputType": "ROW<`a` BIGINT, `b` INT NOT NULL>", | ||
| "description": "Sort(orderBy=[b ASC])" | ||
| }, | ||
| { | ||
| "id": 4, | ||
| "type": "stream-exec-calc_1", | ||
| "projection": [ | ||
| { | ||
| "kind": "INPUT_REF", | ||
| "inputIndex": 0, | ||
| "type": "BIGINT" | ||
| }, | ||
| { | ||
| "kind": "INPUT_REF", | ||
| "inputIndex": 0, | ||
| "type": "BIGINT" | ||
| } | ||
| ], | ||
| "condition": null, | ||
| "inputProperties": [ | ||
| { | ||
| "requiredDistribution": { | ||
| "type": "UNKNOWN" | ||
| }, | ||
| "damBehavior": "PIPELINED", | ||
| "priority": 0 | ||
| } | ||
| ], | ||
| "outputType": "ROW<`a` BIGINT, `a1` BIGINT>", | ||
| "description": "Calc(select=[a, a AS a1])" | ||
| }, | ||
| { | ||
| "id": 5, | ||
| "type": "stream-exec-sink_1", | ||
| "configuration": { | ||
| "table.exec.sink.keyed-shuffle": "AUTO", | ||
| "table.exec.sink.not-null-enforcer": "ERROR", | ||
| "table.exec.sink.rowtime-inserter": "ENABLED", | ||
| "table.exec.sink.type-length-enforcer": "IGNORE", | ||
| "table.exec.sink.upsert-materialize": "AUTO" | ||
| }, | ||
| "dynamicTableSink": { | ||
| "table": { | ||
| "identifier": "`default_catalog`.`default_database`.`MySink`", | ||
| "resolvedTable": { | ||
| "schema": { | ||
| "columns": [ | ||
| { | ||
| "name": "a", | ||
| "dataType": "BIGINT" | ||
| }, | ||
| { | ||
| "name": "b", | ||
| "dataType": "BIGINT" | ||
| } | ||
| ], | ||
| "watermarkSpecs": [] | ||
| }, | ||
| "partitionKeys": [], | ||
| "options": { | ||
| "sink-insert-only": "false", | ||
| "table-sink-class": "DEFAULT", | ||
| "connector": "values" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "inputChangelogMode": [ | ||
| "INSERT" | ||
| ], | ||
| "inputProperties": [ | ||
| { | ||
| "requiredDistribution": { | ||
| "type": "UNKNOWN" | ||
| }, | ||
| "damBehavior": "PIPELINED", | ||
| "priority": 0 | ||
| } | ||
| ], | ||
| "outputType": "ROW<`a` BIGINT, `a1` BIGINT>", | ||
| "description": "Sink(table=[default_catalog.default_database.MySink], fields=[a, a1])" | ||
| } | ||
| ], | ||
| "edges": [ | ||
| { | ||
| "source": 1, | ||
| "target": 2, | ||
| "shuffle": { | ||
| "type": "FORWARD" | ||
| }, | ||
| "shuffleMode": "PIPELINED" | ||
| }, | ||
| { | ||
| "source": 2, | ||
| "target": 3, | ||
| "shuffle": { | ||
| "type": "FORWARD" | ||
| }, | ||
| "shuffleMode": "PIPELINED" | ||
| }, | ||
| { | ||
| "source": 3, | ||
| "target": 4, | ||
| "shuffle": { | ||
| "type": "FORWARD" | ||
| }, | ||
| "shuffleMode": "PIPELINED" | ||
| }, | ||
| { | ||
| "source": 4, | ||
| "target": 5, | ||
| "shuffle": { | ||
| "type": "FORWARD" | ||
| }, | ||
| "shuffleMode": "PIPELINED" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not very familiar with this code; you are saying that the value can come through as either null_xxx or yyy_null.
Is there not a way to test for these nulls prior to calling this.
Also I wonder if you should check for the failure of Integer.valueOf(split[1]); and give a nicer message in that case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the discussion here: #23488 (comment)