Skip to content

Conversation

liyubin117
Copy link
Contributor

What is the purpose of the change

Translate DataSet migration guideline to Chinese
https://nightlies.apache.org/flink/flink-docs-master/zh/docs/dev/datastream/dataset_migration/

Brief change log

  • add translation in docs/content.zh/docs/dev/datastream/dataset_migration.md

Verifying this change

Docs only change.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? no

@liyubin117
Copy link
Contributor Author

@WencongLiu I have finished the translation, PTAL, thanks!

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 6, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@WencongLiu
Copy link
Contributor

@WencongLiu I have finished the translation, PTAL, thanks!

Thanks for the contribution. I'll take a look.

Copy link
Contributor

@WencongLiu WencongLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request looks good overall. But there are some Chinese expressions that don't quite fit the context. I've left some comments. PTAL. 😄

Copy link
Member

@reswqa reswqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WencongLiu and @liyubin117. Nice work, +1 for merging.

@reswqa
Copy link
Member

reswqa commented Nov 13, 2023

@liyubin117 Could you squash all commit?

@liyubin117
Copy link
Contributor Author

@reswqa Squash done :)

@reswqa reswqa merged commit 753f542 into apache:master Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants