[hotfix][table][test] remove duplicated code

[JingGe]

What is the purpose of the change

remove duplicated code according the clean code concept.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (yes / no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
• The serializers: (yes / no / don't know)
• The runtime per-record code paths (performance sensitive): (yes / no / don't know)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
• The S3 file system connector: (yes / no / don't know)

Documentation

• Does this pull request introduce a new feature? (yes / no)

[flinkbot]

CI report:

• 5d950ed Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run azure re-run the last Azure build

[snuyanzin]

I guess this also should be replaced as

TestChangelogResult collectResult = createTestChangelogResult();

[snuyanzin]

Thanks for driving this
i would suggest to replace 2 more same occurrences e.g. at

flink/flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliTableauResultViewTest.java

Lines 374 to 378 in 0c724f5

	collectResult =
	new TestChangelogResult(
	() -> TypedResult.payload(data.subList(0, data.size() / 2)),
	() -> TypedResult.payload(data.subList(data.size() / 2, data.size())),
	TypedResult::endOfStream);

and

flink/flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliTableauResultViewTest.java

Lines 225 to 229 in 0c724f5

	TestChangelogResult collectResult =
	new TestChangelogResult(
	() -> TypedResult.payload(data.subList(0, data.size() / 2)),
	() -> TypedResult.payload(data.subList(data.size() / 2, data.size())),
	TypedResult::endOfStream);

[JingGe]

good catch! Thanks!

[snuyanzin]

nit: it's better to put private/utils methods below all the tests

[snuyanzin]

Thanks for addressing comments 👍
I left a minor one, all the others lgtm

[JingGe]

Thanks @snuyanzin for the review!