[FLINK-33667] Implement restore tests for MatchRecognize node #23821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawidwys
reviewed
Dec 1, 2023
...t/java/org/apache/flink/table/planner/plan/nodes/exec/stream/MatchRecognizeTestPrograms.java
Show resolved
Hide resolved
dawidwys
approved these changes
Dec 5, 2023
| .build(); | ||
|
|
||
| static final TableTestProgram COMPLEX_MATCH = | ||
| TableTestProgram.of("complex-match", "complex match recognize test") |
There was a problem hiding this comment.
Could you please adapt the id according to the javadoc:
?
There was a problem hiding this comment.
Ah, yes; didn't see that. I was reusing identifiers from the existing tests!
Updated.
...t/java/org/apache/flink/table/planner/plan/nodes/exec/stream/MatchRecognizeTestPrograms.java
Show resolved
Hide resolved
FWIW, MR observes the changelog not final results. I think it should be ok to merge before or after the Join PR. |
I don't think it makes a difference. Both access static variables. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Implement restore tests for MatchRecognize node
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation