[FLINK-4559][kinesis-connector] Fix AWSUtil.getCredentialsProvider() to not return null #2470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to not return null Return a DefaultAWSCredentialsProviderChain instead of null when AWS_CREDENTIALS_PROVIDER config is set to "AUTO"
|
Looks good to me. Should we also create a ticket to make AUTO the default as this checks for credentials in multiple places? |
|
Thanks for the review @greghogan. |
|
Merging ... |
haoch
pushed a commit
to haoch/flink
that referenced
this pull request
Sep 10, 2016
…to not return null Return a DefaultAWSCredentialsProviderChain instead of null when AWS_CREDENTIALS_PROVIDER config is set to "AUTO" This closes apache#2470
liuyuzhong
pushed a commit
to liuyuzhong/flink
that referenced
this pull request
Dec 5, 2016
…to not return null Return a DefaultAWSCredentialsProviderChain instead of null when AWS_CREDENTIALS_PROVIDER config is set to "AUTO" This closes apache#2470
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly fixes the Kinesis producer to correctly set credentials on AWS's
KinesisProducerConfigurationwhen using theAUTOoption.Previously the producer was setting credentials for KPL to
nullas returned fromAWSUtil#getCredentialsProvider. Now the method returns aDefaultAWSCredentialsProviderChaininstead.