-
Notifications
You must be signed in to change notification settings - Fork 13.8k
Event latency does not equal window triggering #25664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
eventTime <= timerService.currentWatermark(); This code can only indicate a delayed event, not that the window has been triggered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it worth changing the Chinese file in the this PR as well?
Reviewed by Chi on 21/11/24 Approve - looking for committer to merge. Notice the tests are failing - but this is a docs change ! This should have a Jira or be a HOTFIX - I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution
can you please at least rename PR/commit in order to follow guide
https://flink.apache.org/how-to-contribute/reviewing-prs/
Hello, sorry for the late reply due to work reasons. I just saw it now. I believe the Chinese document should also be modified. |
This PR is being marked as stale since it has not had any activity in the last 90 days. If you are having difficulty finding a reviewer, please reach out to the If this PR is no longer valid or desired, please feel free to close it. |
This PR has been closed since it has not had any activity in 120 days. |
eventTime <= timerService.currentWatermark();
This code can only indicate a delayed event, not that the window has been triggered.
What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)
Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation