Skip to content

[FLINK-4735] [cluster management] Migrate some job execution related akka messages to rpc calls #2588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[FLINK-4735] [cluster management] Migrate some job execution related akka messages to rpc calls #2588

wants to merge 5 commits into from

Conversation

KurtYoung
Copy link
Contributor

This includes the following operations about job execution:

  1. checkpointing
  2. kvstate
  3. savepoint
  4. classloading props

@StephanEwen
Copy link
Contributor

Looks good, thanks, will merge this.

I would suggest two followups:

  • We can remove the "dispose savepoint" method, because that is functionality disappearing right now. Savepoints need no special remove logic any more, they are just a directory in a filesystem.
  • We can reduce the number of message classes (like TriggerSavepointResponse) by using exceptions more prominently. The "triggerSavepoint()" method could simply return a String (success) or throw an exception (failure). Exceptions are propagated by the RPC, so the caller future will always get it as a response.

@KurtYoung
Copy link
Contributor Author

@StephanEwen Sounds reasonable. This PR has some overlayer with #2594, will address your comment after that one merged and rebase to the latest flip-6 branch

KurtYoung and others added 5 commits October 13, 2016 20:28
@KurtYoung
[FLINK-4735] [cluster management] Implements some job execution relat…
c074214 
…ed RPC calls on the JobManager
@StephanEwen @KurtYoung
[FLINK-4776] [distributed coordination] Move ExecutionGraph initializ…
3cdafc3 
…ation into the dedicated class ExecutionGraphBuilder
@StephanEwen @KurtYoung
[FLINK-4764] [core] Introduce Config Options
16b3e5f 
This is a more concise and maintainable way to define configuration keys, default values,
deprecated keys, etc.

This closes apache#2605
@StephanEwen @KurtYoung
[FLINK-4768] [core] Migrate high-availability configuration parameter…
9d5bca7 
…s to ConfigOptions

This closes apache#2607
@KurtYoung
[FLINK-4375] [distributed coordination] Implement new JobManager crea…
46169d0 
…tion, initialization, and basic RPC methods
@KurtYoung
Copy link
Contributor Author

This PR now contains some work from master branch picked by Stephan.
Rebased to the latest flip-6

@KurtYoung KurtYoung mentioned this pull request Oct 13, 2016
Closed
@StephanEwen
Copy link
Contributor

Merged to the flip-6 feature branch in 34fef47

@KurtYoung KurtYoung closed this Oct 14, 2016
@KurtYoung KurtYoung deleted the flink-4735 branch October 17, 2016 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component=Runtime/Coordination
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KurtYoung @StephanEwen @rmetzger