Skip to content

Conversation

raminqaf
Copy link
Contributor

@raminqaf raminqaf commented Oct 2, 2025

What is the purpose of the change

This pull request fixes a type inconsistency in CreateMaterializedTableOperation where the getter method returns the parent type CatalogMaterializedTable instead of the actual stored type ResolvedCatalogMaterializedTable. This creates unnecessary type loss and is inconsistent with similar operations like CreateTableOperation which correctly returns ResolvedCatalogTable.

Brief change log

  • Changed CreateMaterializedTableOperation.getCatalogMaterializedTable() return type from CatalogMaterializedTable to ResolvedCatalogMaterializedTable to match the field type and align with the pattern used in CreateTableOperation

Verifying this change

This change is already covered by existing tests, such as:

  • All existing tests continue to pass since ResolvedCatalogMaterializedTable implements CatalogMaterializedTable (safe covariant return type change)

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no (class is @Internal)
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 2, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

this.tableName = requireNonNull(tableName, "tableName should not be null");
this.comment = comment;
this.tableConstraint = tableConstraint;
this.comment = comment;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ordered the fields they way they are defined in the constructor

@github-actions github-actions bot added the community-reviewed PR has been reviewed by the community. label Oct 2, 2025
@snuyanzin snuyanzin merged commit 1c6574d into apache:master Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-reviewed PR has been reviewed by the community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants