[FLINK-5109] fix invalid content-encoding header of webmonitor #2892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allowing Trigger.onMerge() to return a TriggerResult is not necessary since an onMerge() call will always be followed by an onElement() call when adding the element that caused the merging to the merged window. Having this complicates the internal logic of the WindowOperator and makes writing Triggers more confusing than it has to be.
This transitive dependency has an incompatible license. This closes #2824
… AbstractTaskManagerProcessFailureRecoveryTest
…s and state backends
…ution This closes #2823.
|
Hi @Hapcy, thanks for submitting this PR. It's best to create a feature branch for each ticket rather than committing to master. You can fix this by creating a branch (git checkout master ; git checkout -b 5109_invalid_content_encoding_header_in_rest_api_responses) then resetting master (git checkout master ; git reset --hard 7f1c76d^ ; git rebase upstream/master) then rebasing against master (git checkout 5109_invalid_content_encoding_header_in_rest_api_responses ; git rebase master ; git push -f origin 5109_invalid_content_encoding_header_in_rest_api_responses). Something like that. Make a copy of everything first. |
|
Thank you for your feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.
General
Documentation --- not touched
Tests & Build
mvn clean verifyhas been executed successfully locally or a Travis build has passed --- Travis build failed but I had nothing to do with those parts of the code.I'm kind of newbie and some other people's commits showed up as commited with me but I have nothing to do with them.