-
Notifications
You must be signed in to change notification settings - Fork 13.8k
DistCache: executable flag, dir support #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here, you could have also done if(content.isDir() && distPath.endsWith("/"))
to save one if
statement.
But you don't need to update the PR for that ;)
shortened nested ifs removed exception swallowing
This is merged in f952638 |
rmetzger
referenced
this pull request
in rmetzger/flink
Jul 13, 2014
Duplicated codes in StreamSink, StreamSource, StreamTask has been encapsulated into StreamComponentFactory. Test passed. Commented codes may be removed if no further modification is needed.
StephanEwen
referenced
this pull request
in StephanEwen/flink
Jul 13, 2014
Duplicated codes in StreamSink, StreamSource, StreamTask has been encapsulated into StreamComponentFactory. Test passed. Commented codes may be removed if no further modification is needed.
StephanEwen
referenced
this pull request
in StephanEwen/flink
Jul 14, 2014
StephanEwen
referenced
this pull request
in StephanEwen/flink
Aug 18, 2014
tillrohrmann
referenced
this pull request
in tillrohrmann/flink
Jan 17, 2015
mxm
added a commit
to mxm/flink
that referenced
this pull request
Feb 2, 2015
mxm
added a commit
to mxm/flink
that referenced
this pull request
Feb 2, 2015
mxm
added a commit
to mxm/flink
that referenced
this pull request
Feb 2, 2015
mxm
added a commit
to mxm/flink
that referenced
this pull request
Feb 3, 2015
mxm
added a commit
to mxm/flink
that referenced
this pull request
Feb 29, 2016
mxm
added a commit
to mxm/flink
that referenced
this pull request
Feb 29, 2016
fijolekProjects
added a commit
to fijolekProjects/flink
that referenced
this pull request
Jul 9, 2016
smarthi
pushed a commit
to smarthi/flink
that referenced
this pull request
Jul 29, 2016
VenturaDelMonte
added a commit
to VenturaDelMonte/flink
that referenced
this pull request
Sep 29, 2016
VenturaDelMonte
added a commit
to VenturaDelMonte/flink
that referenced
this pull request
Oct 5, 2016
VenturaDelMonte
added a commit
to VenturaDelMonte/flink
that referenced
this pull request
Nov 4, 2016
dawidwys
referenced
this pull request
in dawidwys/flink
Mar 1, 2017
dawidwys
referenced
this pull request
in dawidwys/flink
Mar 1, 2017
3 tasks
aditiverma
pushed a commit
to aditiverma/flink
that referenced
this pull request
May 28, 2018
added circle to publish internal build
Jiayi-Liao
pushed a commit
to Jiayi-Liao/flink
that referenced
this pull request
Nov 7, 2018
Watermarks相关单元测试修复
This was referenced Sep 30, 2016
walterddr
pushed a commit
to walterddr/flink
that referenced
this pull request
Apr 27, 2019
chaojianok
added a commit
to chaojianok/flink
that referenced
this pull request
Jun 30, 2020
Merge from apache/flink master
rkhachatryan
added a commit
to rkhachatryan/flink
that referenced
this pull request
Sep 8, 2021
TODO: squash with other commits
rkhachatryan
added a commit
to rkhachatryan/flink
that referenced
this pull request
Sep 8, 2021
TODO: squash with other commits
rkhachatryan
added a commit
to rkhachatryan/flink
that referenced
this pull request
Sep 16, 2021
chengkaiyang2025
added a commit
to chengkaiyang2025/flink-25705
that referenced
this pull request
May 2, 2022
parent 8d00622 author Chengkai Yang <yangchengkai2022@163.com> 1650023265 +0800 committer Chengkai Yang <yangchengkai2022@163.com> 1651508979 +0800 # This is a combination of 3 commits. # This is the 1st commit message: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment" in to Chinese. # This is the commit message apache#2: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment" in to Chinese. # This is the commit message apache#3: [FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment" in to Chinese. # This is the commit message apache#4: [FLINK-25705][docs]Translate some description in the table of html file.
HuangZhenQiu
pushed a commit
to HuangZhenQiu/flink
that referenced
this pull request
Sep 20, 2022
Closes apache#3
yuta-cloud
pushed a commit
to yuta-cloud/flink-me
that referenced
this pull request
Apr 27, 2023
Switch to shaded guava version to ensure successful builds
cbornet
added a commit
to cbornet/flink
that referenced
this pull request
Jun 6, 2023
* Fix default database in tests * Fix default database in tests
morozov
pushed a commit
to morozov/flink
that referenced
this pull request
Apr 26, 2024
* build using java 11 * ci/cd test run * scoping run cancels to workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new features:
listStatus
recursively)other changes:
NepheleJobGraphGenerator
orTaskManager
for this)